I suppose anyone using dumpSignatures (and I agree, I think it's vanishingly unlikely, really) would necessarily be developer-qualified to mutate the new entry point, yes... I'll buy that.
On the checkstyle, I'd thought I knew my alphabet for sorting... _why_ doesn't checkstyle complain? (In particular, looking at last capitalized term, it's correctly sorted C,S,U... maybe it's ignoring the non-terminal capitalized term??) I'll give you the LGTM if it's not failing the test, though. On Fri, Sep 3, 2010 at 7:05 PM, <[email protected]> wrote: > I can't imagine anyone using the feature. If they really, really care > they could just copy the new entry point and make their own, and it > would run much faster than doing a full compile anyway. > > > > http://gwt-code-reviews.appspot.com/844801/diff/1/6 > File dev/core/src/com/google/gwt/dev/Precompile.java (right): > > http://gwt-code-reviews.appspot.com/844801/diff/1/6#newcode43 > dev/core/src/com/google/gwt/dev/Precompile.java:43: import > com.google.gwt.dev.shell.StandardRebindOracle; > On 2010/09/03 21:10:23, fabbott wrote: > >> isn't this bad checkstyle alpha-sorting, 'C' < 'S'? >> > > Dunno, but that's how Eclipse auto-sorted it, and Checkstyle isn't > complaining. > > > http://gwt-code-reviews.appspot.com/844801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
