LGTM

Thanks, Ray. One wording nit.


http://gwt-code-reviews.appspot.com/831803/diff/1/3
File user/src/com/google/gwt/user/client/ui/HasValue.java (right):

http://gwt-code-reviews.appspot.com/831803/diff/1/3#newcode48
user/src/com/google/gwt/user/client/ui/HasValue.java:48: * <p>
How about:

Widgets must accept null as a valid value. By convention, setting a
widget to null clears its value, calling getValue() on a cleared widget
returns null. Widgets that cannot be cleared (e.g. {...@link CheckBox})
must find another valid meaning for null input.

http://gwt-code-reviews.appspot.com/831803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to