http://gwt-code-reviews.appspot.com/751801/diff/1/2
File user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java
(right):

http://gwt-code-reviews.appspot.com/751801/diff/1/2#newcode73
user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java:73:
this(streamFactory, methodName, new RpcStatsContext(requestId),
callback);
Since this type lives in an impl package, it's not strictly necessary to
retain backwards API compatibility.

http://gwt-code-reviews.appspot.com/751801/diff/1/6
File user/src/com/google/gwt/user/client/rpc/impl/RpcStatsContext.java
(right):

http://gwt-code-reviews.appspot.com/751801/diff/1/6#newcode47
user/src/com/google/gwt/user/client/rpc/impl/RpcStatsContext.java:47:
return RemoteServiceProxy.stats(data);
I think it would make sense to move the implementations from
RemoteServiceProxy into this type.  If a polymorphic method makes no
actual references to the "this" object, it will wind up be a a
static-dispatch method, and inlined.

http://gwt-code-reviews.appspot.com/751801/diff/1/4
File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right):

http://gwt-code-reviews.appspot.com/751801/diff/1/4#newcode453
user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java:453: +
statsMethodExpr + "\",  \"begin\"));");
SourceWriter now has printf-style methods on it.  That might make this a
bit cleaner.

http://gwt-code-reviews.appspot.com/751801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to