I think LGTM, but could you help me understand CompositeEditor and CompositeEditor.Chain first?
http://gwt-code-reviews.appspot.com/848801/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/2#newcode46 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java:46: final TakesValueEditor<String> streetEditor; Nice! http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20 user/src/com/google/gwt/editor/client/CompositeEditor.java:20: * some other type. Having trouble getting my head around this. Could you update doc give an example of base and component types? Or just describe the use case that lead you to create this? I'm lost. http://gwt-code-reviews.appspot.com/848801/diff/1/16 File user/src/com/google/gwt/editor/client/adapters/ListEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/16#newcode29 user/src/com/google/gwt/editor/client/adapters/ListEditor.java:29: * Manages to manage a list and some editors. Manages to manage :-) ? http://gwt-code-reviews.appspot.com/848801/diff/1/16#newcode34 user/src/com/google/gwt/editor/client/adapters/ListEditor.java:34: public class ListEditor<T, E extends Editor<T>> implements You need E as input to the code generator, right? http://gwt-code-reviews.appspot.com/848801/diff/1/26 File user/src/com/google/gwt/editor/client/testing/FakeEditorSource.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/26#newcode29 user/src/com/google/gwt/editor/client/testing/FakeEditorSource.java:29: public class FakeEditorSource<T> extends EditorSource<FakeLeafValueEditor<T>> { Should the fakes and mocks live in user/test? Or would that make them not available to third parties? http://gwt-code-reviews.appspot.com/848801/diff/1/37 File user/test/com/google/gwt/editor/client/SimpleBeanEditorTest.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/37#newcode299 user/test/com/google/gwt/editor/client/SimpleBeanEditorTest.java:299: class StringSource extends EditorSource<SimpleEditor<String>> { Will I always have to create a source to use a ListEditor? Could it be generated? http://gwt-code-reviews.appspot.com/848801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
