http://gwt-code-reviews.appspot.com/827802/diff/4001/5007 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right):
http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode76 user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:76: // ETypeSeedName~"9~FieldName On 2010/09/09 21:06:16, bobv wrote:
// ETypeSeedName~IOrdinal~
Done. http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode80 user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:80: accept(new IntValueCommand(x.getValue().ordinal())); On 2010/09/09 21:06:16, bobv wrote:
Use appendTypedData here. The use of accept() is because Strings can
be encoded
as a backreference.
Done. http://gwt-code-reviews.appspot.com/827802/diff/4001/5008 File user/src/com/google/gwt/rpc/server/SimplePayloadDecoder.java (right): http://gwt-code-reviews.appspot.com/827802/diff/4001/5008#newcode201 user/src/com/google/gwt/rpc/server/SimplePayloadDecoder.java:201: // ETypeSeedName~"9~FieldName On 2010/09/09 21:06:16, bobv wrote:
// ETypeSeedName~IOrdinal~
Done. http://gwt-code-reviews.appspot.com/827802/diff/4001/5008#newcode212 user/src/com/google/gwt/rpc/server/SimplePayloadDecoder.java:212: x.setValue(enumConstants[ordinal]); On 2010/09/09 21:06:16, bobv wrote:
Please add a TODO here to the effect of: This is prone to subtle
corruption or
an ArrayIndexOutOfBoundsException if the client and server have
drifted. Done. http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
