Reviewers: bobv,

http://gwt-code-reviews.appspot.com/862801/diff/2001/3001
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(left):

http://gwt-code-reviews.appspot.com/862801/diff/2001/3001#oldcode372
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:372:
}
This change is about greatly improving the error output when something
goes wrong.  Throwing UnableToComplete here causes rather useless stack
traces to happen; not throwing results in the actual compile errors in
the generated code being readable.

http://gwt-code-reviews.appspot.com/862801/diff/2001/3005
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(left):

http://gwt-code-reviews.appspot.com/862801/diff/2001/3005#oldcode280
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:280:
composerFactory.addImport(SerializationStreamWriter.class.getName());
Turns out these weren't needed anymore.



Please review this at http://gwt-code-reviews.appspot.com/862801/show

Affected files:
  M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
  M dev/core/src/com/google/gwt/dev/jdt/WebModeCompilerFrontEnd.java
  M dev/core/test/com/google/gwt/dev/shell/StandardGeneratorContextTest.java
  M user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
  M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to