http://gwt-code-reviews.appspot.com/864801/diff/3001/4013 File user/src/com/google/gwt/user/client/ui/HasOneWidget.java (right):
http://gwt-code-reviews.appspot.com/864801/diff/3001/4013#newcode28 user/src/com/google/gwt/user/client/ui/HasOneWidget.java:28: public Widget getWidget(); On 2010/09/12 11:03:49, tbroyer wrote:
The asymmetry between setWidget taking an IsWidget, and getWidget
returning a
Widget looks weird.
Agreed. I think we've been using "TakesX" to indicate having both a getter and setter. HasOneWidget = Widget getWidget(); AcceptsOneWidget = setWidget(IsWidget w); http://gwt-code-reviews.appspot.com/864801/diff/3001/4015 File user/src/com/google/gwt/user/client/ui/HorizontalPanel.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4015#newcode34 user/src/com/google/gwt/user/client/ui/HorizontalPanel.java:34: Extra blank link? Probably from doing a method sort. http://gwt-code-reviews.appspot.com/864801/diff/3001/4016 File user/src/com/google/gwt/user/client/ui/IndexedPanel.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4016#newcode30 user/src/com/google/gwt/user/client/ui/IndexedPanel.java:30: * /** Gets the child widget at the specified index. Copy-paste? http://gwt-code-reviews.appspot.com/864801/diff/3001/4018 File user/src/com/google/gwt/user/client/ui/IsWidget.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4018#newcode27 user/src/com/google/gwt/user/client/ui/IsWidget.java:27: * @return the {...@link Widget} aspect of the rceiver rEceiver http://gwt-code-reviews.appspot.com/864801/diff/3001/4021 File user/src/com/google/gwt/user/client/ui/SimplePanel.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4021#newcode47 user/src/com/google/gwt/user/client/ui/SimplePanel.java:47: Extra whitespace. http://gwt-code-reviews.appspot.com/864801/diff/3001/4023 File user/src/com/google/gwt/user/client/ui/StackPanel.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4023#newcode51 user/src/com/google/gwt/user/client/ui/StackPanel.java:51: This blank line looks misplaced. http://gwt-code-reviews.appspot.com/864801/diff/3001/4024 File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4024#newcode264 user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java:264: Whitespace. http://gwt-code-reviews.appspot.com/864801/diff/3001/4025 File user/src/com/google/gwt/user/client/ui/TabPanel.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4025#newcode323 user/src/com/google/gwt/user/client/ui/TabPanel.java:323: Whitespace. http://gwt-code-reviews.appspot.com/864801/diff/3001/4027 File user/src/com/google/gwt/user/client/ui/Widget.java (right): http://gwt-code-reviews.appspot.com/864801/diff/3001/4027#newcode57 user/src/com/google/gwt/user/client/ui/Widget.java:57: Blank line. http://gwt-code-reviews.appspot.com/864801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
