LGTM, assuming the RTL CSS question is answered.

http://gwt-code-reviews.appspot.com/837801/diff/1/2
File
samples/showcase/src/com/google/gwt/i18n/client/LocalizableResource.properties
(right):

http://gwt-code-reviews.appspot.com/837801/diff/1/2#newcode1
samples/showcase/src/com/google/gwt/i18n/client/LocalizableResource.properties:1:
mainMenuTitle = GWT Examples
What is the order of this file?  It seems kind of haphazard.

I know this isn't part of this change, but I think these should all be
in annotations in the associated interfaces instead of a separate
properties file.  That allows you to include additional information,
such as the description or meanings, and you can then also take
advantage of things like key generation to avoid potential name
conflicts (important since you are putting all these translations on
LocalizableResource).

It also seems strange to combine most of the translations into
LocalizableResource*.properties, but still have other ones (though I
suppose that makes it easier to include just the relevant snippet in the
example code).

http://gwt-code-reviews.appspot.com/837801/diff/1/70
File
samples/showcase/src/com/google/gwt/sample/showcase/generator/ShowcaseGenerator.java
(right):

http://gwt-code-reviews.appspot.com/837801/diff/1/70#newcode107
samples/showcase/src/com/google/gwt/sample/showcase/generator/ShowcaseGenerator.java:107:
String[] themes = new String[]{"standard"};
Is the formatting right here?

http://gwt-code-reviews.appspot.com/837801/diff/1/76
File
samples/showcase/src/com/google/gwt/sample/showcase/public/standard/Showcase_rtl.css
(left):

http://gwt-code-reviews.appspot.com/837801/diff/1/76#oldcode2
samples/showcase/src/com/google/gwt/sample/showcase/public/standard/Showcase_rtl.css:2:
* Applied to the main layout of the page.
Where did the RTL CSS go?

http://gwt-code-reviews.appspot.com/837801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to