[gwt-contrib] Re: Add stack trace display to the rest of the log handlers in dev mode (issue861801)

[unnurg]

http://gwt-code-reviews.appspot.com/861801/diff/1/6
File user/src/com/google/gwt/logging/client/HtmlLogFormatter.java
(right):

http://gwt-code-reviews.appspot.com/861801/diff/1/6#newcode98
user/src/com/google/gwt/logging/client/HtmlLogFormatter.java:98: text =
text.replaceAll("&lt;br&gt;", "<br>");
On 2010/09/13 18:05:31, fredsa wrote:

This potentially has the side effect of replacing <br> in user

output with

<br>, which would be unexpected.

Good call - changed

http://gwt-code-reviews.appspot.com/861801/diff/1/9
File user/src/com/google/gwt/logging/impl/FormatterImpl.java (right):

http://gwt-code-reviews.appspot.com/861801/diff/1/9#newcode31
user/src/com/google/gwt/logging/impl/FormatterImpl.java:31: protected
String getRecordInfo(LogRecord event, String newline) {
On 2010/09/13 18:05:31, fredsa wrote:

Add a JavaDoc to either indicate what the defined format is of the

returned

string, or indicate that the format is subject to change in the

future.

Done.

http://gwt-code-reviews.appspot.com/861801/diff/1/9#newcode45
user/src/com/google/gwt/logging/impl/FormatterImpl.java:45: // should be
moved there and not duplicated here.
On 2010/09/13 18:05:31, fredsa wrote:

I think it would be good to rephrase the comment as a TODO

Done.

http://gwt-code-reviews.appspot.com/861801/diff/1/9#newcode52
user/src/com/google/gwt/logging/impl/FormatterImpl.java:52: return "";
On 2010/09/13 18:05:31, fredsa wrote:

We should still print a stack trace in production mode, even if it is
obfuscated. The app may have been compiled with -style PRETTY or

DETAILED, and

perhaps with compiler.emulatedStack enabled, making the stack traces

quite

useful.

If you like, add a TODO to use server side resymbolization to provide
de-obfuscated stack traces to client side code.

Done.

http://gwt-code-reviews.appspot.com/861801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors