More comments:
- Add tests to ensure that onViolation and onError methods are called?
- Additionally, remove the violations field from SyncResult and fix
AbstractProxyEditActivity?
- Similarly, the tests in RequestFactoryTest that check for violations
will need to be fixed.




http://gwt-code-reviews.appspot.com/855802/diff/1/7
File user/src/com/google/gwt/requestfactory/shared/Violation.java
(right):

http://gwt-code-reviews.appspot.com/855802/diff/1/7#newcode31
user/src/com/google/gwt/requestfactory/shared/Violation.java:31:
EntityProxy getProxy();
Use EntityProxyId instead?

http://gwt-code-reviews.appspot.com/855802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to