LGTM

ErrorPanel didn't work out, eh?

Delegate map is required for interpreting violation paths?


http://gwt-code-reviews.appspot.com/877801/diff/2001/3003
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java
(right):

http://gwt-code-reviews.appspot.com/877801/diff/2001/3003#newcode35
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java:35:
ValueBoxEditorDecorator<String> street;
That's quite a mouthful. Don't have a better name off the top of my
head, though.

http://gwt-code-reviews.appspot.com/877801/diff/2001/3005
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java
(right):

http://gwt-code-reviews.appspot.com/877801/diff/2001/3005#newcode49
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java:49:
@Ignore
How come?

http://gwt-code-reviews.appspot.com/877801/diff/2001/3009
File user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
(right):

http://gwt-code-reviews.appspot.com/877801/diff/2001/3009#newcode53
user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java:53:
getDelegate().recordError(e.getMessage(), peer.getText(), e);
// TODO i18n
 getDelegate().recordError(e.getMessage(), "Bad value (" +
peer.getText() + ")", e);

http://gwt-code-reviews.appspot.com/877801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to