Updated another patch.

On Tue, Sep 14, 2010 at 5:21 PM, <[email protected]> wrote:

>
> http://gwt-code-reviews.appspot.com/878801/diff/1/6
> File
>
> user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
> (right):
>
> http://gwt-code-reviews.appspot.com/878801/diff/1/6#newcode296
>
> user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:296:
> Long.class);
> Shouldn't you make this Object.class to keep from creating more work for
> Stephany?
>
>
That fails with "Method not found" since the method signature still expects
Long (in our tests, samples, etc.).


> http://gwt-code-reviews.appspot.com/878801/diff/1/8
> File user/src/com/google/gwt/requestfactory/shared/RequestFactory.java
> (right):
>
> http://gwt-code-reviews.appspot.com/878801/diff/1/8#newcode39
> user/src/com/google/gwt/requestfactory/shared/RequestFactory.java:39:
> FindRequest findRequest();
> What happened to making the public api
>
> ProxyRequest<EntityProxy> find(EntityProxyId proxyId)
>
> And putting this declaration into RFJsonImpl, along with an impl of
> find(EntityProxyId) that calls it.
>
> We're trying to freeze the API, no one else can swing back and clean it
> up. Last chance.
>
>
Fixed in the just uploaded patch.


>
> http://gwt-code-reviews.appspot.com/878801/show
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to