LGTM + a couple of simple questions

http://gwt-code-reviews.appspot.com/882801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):

http://gwt-code-reviews.appspot.com/882801/diff/1/4#newcode733
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:733:
optimizeJsEvent.end();
it might be useful to annotate the optimizeJsEvent with the contents of
stats.prettyPrint() -- if that isn't too large.

http://gwt-code-reviews.appspot.com/882801/diff/1/9
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java
(right):

http://gwt-code-reviews.appspot.com/882801/diff/1/9#newcode38
dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java:38:
OPTIMIZE_JS("OptimizeJs", "#8b8bab"), //
just double checking: you meant to add OPTIMIZE_JS as an additional
type, not rename OPTIMIZE here, right?

http://gwt-code-reviews.appspot.com/882801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to