LGTM On Wed, Sep 15, 2010 at 11:17 AM, <[email protected]> wrote:
> Reviewers: amitmanjhi, > > Description: > Fix warnings and checkstyle errors > > > Please review this at http://gwt-code-reviews.appspot.com/882802/show > > Affected files: > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java > M user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java > M user/src/com/google/gwt/app/place/AbstractProxyListView.java > M user/src/com/google/gwt/app/place/WithTokenizers.java > M user/src/com/google/gwt/cell/client/IconCellDecorator.java > M user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java > M user/src/com/google/gwt/editor/rebind/model/EditorAccess.java > M > user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java > M user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java > M user/src/com/google/gwt/requestfactory/shared/RequestEvent.java > M user/src/com/google/gwt/requestfactory/shared/RequestObject.java > M user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java > M user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java > M user/src/com/google/gwt/user/client/ui/HTML.java > M user/src/com/google/gwt/user/client/ui/HasOneWidget.java > M user/src/com/google/gwt/user/client/ui/IsWidget.java > M > user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java > M > user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java > M > user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java > M user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java > M user/src/com/google/gwt/validation/client/impl/NodeImpl.java > M user/src/com/google/gwt/validation/rebind/AbstractCreator.java > M user/test/com/google/gwt/app/place/ActivityManagerTest.java > M user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java > M user/test/com/google/gwt/validation/client/SimpleSample.java > M > user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java > M > user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java > M > user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java > M > user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java > M > user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java > M > user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java > M > user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java > M > user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java > M > user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java > M > user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java > M > user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java > M > user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java > M > user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java > M > user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java > M > user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBooleanTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByteTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfCharTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDoubleTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloatTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfIntTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLongTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObjectTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShortTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForCollectionTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForMapTest.java > M > user/test/com/google/gwt/validation/client/constraints/SizeValidatorForStringTest.java > M user/test/com/google/gwt/validation/example/client/Author.java > M user/test/com/google/gwt/validation/example/client/FirstLevelCheck.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
