Revision: 8791
Author: [email protected]
Date: Wed Sep 15 12:32:43 2010
Log: Moved Property and EnumProperty from the
com.google.gwt.requestfactory.client.impl package to
com.google.gwt.requestfactory.shared.impl package.

Review at http://gwt-code-reviews.appspot.com/881801

Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=8791

Added:
 /trunk/user/src/com/google/gwt/requestfactory/shared/impl
 /trunk/user/src/com/google/gwt/requestfactory/shared/impl/EnumProperty.java
 /trunk/user/src/com/google/gwt/requestfactory/shared/impl/Property.java
Deleted:
 /trunk/user/src/com/google/gwt/requestfactory/client/impl/EnumProperty.java
 /trunk/user/src/com/google/gwt/requestfactory/client/impl/Property.java
Modified:
 /trunk/user/src/com/google/gwt/app/rebind/EditorSupportGenerator.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java
 /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java
 /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java
 /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java
/trunk/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
 /trunk/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java
/trunk/user/test/com/google/gwt/requestfactory/client/impl/SimpleBazProxyImpl.java /trunk/user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java

=======================================
--- /dev/null
+++ /trunk/user/src/com/google/gwt/requestfactory/shared/impl/EnumProperty.java Wed Sep 15 12:32:43 2010
@@ -0,0 +1,49 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.requestfactory.shared.impl;
+
+
+/**
+ * <p>
+ * <span style="color:red">Experimental API: This class is still under rapid
+ * development, and is very likely to be deleted. Use it at your own risk.
+ * </span>
+ * </p>
+ * Defines a property of a {...@link com.google.gwt.requestfactory.shared.EntityProxy}.
+ *
+ * @param <V> the type of the property's value
+ */
+public class EnumProperty<V> extends Property<V> {
+
+  private V[] values;
+
+  /**
+   * @param name the property's name and displayName
+   * @param type the class of the property's value
+   * @param values the result of Enum.values() method
+   */
+  public EnumProperty(String name, Class<V> type, V[] values) {
+    super(name, type);
+    this.values = values;
+  }
+
+  /**
+   * Returns the values that the enum may take on.
+   */
+  public V[] getValues() {
+    return values;
+  }
+}
=======================================
--- /dev/null
+++ /trunk/user/src/com/google/gwt/requestfactory/shared/impl/Property.java Wed Sep 15 12:32:43 2010
@@ -0,0 +1,63 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.requestfactory.shared.impl;
+
+/**
+ * <p>
+ * <span style="color:red">Experimental API: This class is still under rapid
+ * development, and is very likely to be deleted. Use it at your own risk.
+ * </span>
+ * </p>
+ * Defines a property of a {...@link EntityProxy}.
+ *
+ * @param <V> the type of the property's value
+ */
+public class Property<V> {
+  private final String name;
+  private final Class<V> type;
+  private final String displayName;
+
+  /**
+   * @param name the property's name and displayName
+   * @param type the class of the property's value
+   */
+  public Property(String name, Class<V> type) {
+    this(name, name, type);
+  }
+
+  /**
+   * @param name the property's name
+   * @param displayName the property's user visible name
+   * @param type the class of the property's value
+   */
+  public Property(String name, String displayName, Class<V> type) {
+    this.name = name;
+    this.displayName = displayName;
+    this.type = type;
+  }
+
+  public String getDisplayName() {
+    return displayName;
+  }
+
+  public String getName() {
+    return name;
+  }
+
+  public Class<V> getType() {
+    return type;
+  }
+}
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/EnumProperty.java Tue Sep 14 17:54:04 2010
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not - * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.google.gwt.requestfactory.client.impl;
-
-/**
- * <p>
- * <span style="color:red">Experimental API: This class is still under rapid
- * development, and is very likely to be deleted. Use it at your own risk.
- * </span>
- * </p>
- * Defines a property of a {...@link com.google.gwt.requestfactory.shared.EntityProxy}.
- *
- * @param <V> the type of the property's value
- */
-public class EnumProperty<V> extends Property<V> {
-
-  private V[] values;
-
-  /**
-   * @param name the property's name and displayName
-   * @param type the class of the property's value
-   * @param values the result of Enum.values() method
-   */
-  public EnumProperty(String name, Class<V> type, V[] values) {
-    super(name, type);
-    this.values = values;
-  }
-
-  /**
-   * Returns the values that the enum may take on.
-   */
-  public V[] getValues() {
-    return values;
-  }
-}
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/Property.java Tue Sep 14 17:54:04 2010
+++ /dev/null
@@ -1,63 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not - * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.google.gwt.requestfactory.client.impl;
-
-/**
- * <p>
- * <span style="color:red">Experimental API: This class is still under rapid
- * development, and is very likely to be deleted. Use it at your own risk.
- * </span>
- * </p>
- * Defines a property of a {...@link EntityProxy}.
- *
- * @param <V> the type of the property's value
- */
-public class Property<V> {
-  private final String name;
-  private final Class<V> type;
-  private final String displayName;
-
-  /**
-   * @param name the property's name and displayName
-   * @param type the class of the property's value
-   */
-  public Property(String name, Class<V> type) {
-    this(name, name, type);
-  }
-
-  /**
-   * @param name the property's name
-   * @param displayName the property's user visible name
-   * @param type the class of the property's value
-   */
-  public Property(String name, String displayName, Class<V> type) {
-    this.name = name;
-    this.displayName = displayName;
-    this.type = type;
-  }
-
-  public String getDisplayName() {
-    return displayName;
-  }
-
-  public String getName() {
-    return name;
-  }
-
-  public Class<V> getType() {
-    return type;
-  }
-}
=======================================
--- /trunk/user/src/com/google/gwt/app/rebind/EditorSupportGenerator.java Tue Sep 14 17:54:04 2010 +++ /trunk/user/src/com/google/gwt/app/rebind/EditorSupportGenerator.java Wed Sep 15 12:32:43 2010
@@ -30,8 +30,8 @@
 import com.google.gwt.dom.client.Style.FontWeight;
 import com.google.gwt.event.logical.shared.ValueChangeEvent;
 import com.google.gwt.event.logical.shared.ValueChangeHandler;
-import com.google.gwt.requestfactory.client.impl.Property;
 import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.impl.Property;
 import com.google.gwt.uibinder.client.UiField;
 import com.google.gwt.user.client.TakesValue;
 import com.google.gwt.user.client.ui.HasText;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java Tue Sep 14 17:54:04 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java Wed Sep 15 12:32:43 2010
@@ -16,6 +16,7 @@
 package com.google.gwt.requestfactory.client.impl;

 import com.google.gwt.core.client.JavaScriptObject;
+
 import com.google.gwt.core.client.JsArray;
import com.google.gwt.requestfactory.client.impl.DeltaValueStoreJsonImpl.ReturnRecord;
 import com.google.gwt.requestfactory.shared.EntityProxy;
@@ -25,6 +26,7 @@
 import com.google.gwt.requestfactory.shared.ServerFailure;
 import com.google.gwt.requestfactory.shared.SyncResult;
 import com.google.gwt.requestfactory.shared.Violation;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import java.util.Collection;
 import java.util.Collections;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java Tue Sep 14 17:54:04 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java Wed Sep 15 12:32:43 2010
@@ -16,12 +16,14 @@
 package com.google.gwt.requestfactory.client.impl;

 import com.google.gwt.core.client.JavaScriptObject;
+
 import com.google.gwt.core.client.JsArray;
 import com.google.gwt.requestfactory.client.SyncResultImpl;
 import com.google.gwt.requestfactory.shared.EntityProxy;
 import com.google.gwt.requestfactory.shared.EntityProxyId;
 import com.google.gwt.requestfactory.shared.SyncResult;
 import com.google.gwt.requestfactory.shared.WriteOperation;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import java.util.HashMap;
 import java.util.HashSet;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java Wed Sep 15 02:57:26 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java Wed Sep 15 12:32:43 2010
@@ -16,7 +16,9 @@
 package com.google.gwt.requestfactory.client.impl;

 import com.google.gwt.requestfactory.shared.EntityProxy;
+
 import com.google.gwt.requestfactory.shared.EntityProxyId;
+import com.google.gwt.requestfactory.shared.impl.Property;

 /**
  * <p>
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java Wed Sep 15 02:57:26 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java Wed Sep 15 12:32:43 2010
@@ -16,10 +16,12 @@
 package com.google.gwt.requestfactory.client.impl;

 import com.google.gwt.core.client.GWT;
+
 import com.google.gwt.core.client.JavaScriptObject;
 import com.google.gwt.core.client.JsArray;
 import com.google.gwt.requestfactory.shared.EntityProxy;
 import com.google.gwt.requestfactory.shared.EntityProxyId;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import java.math.BigDecimal;
 import java.math.BigInteger;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java Tue Sep 14 17:54:04 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java Wed Sep 15 12:32:43 2010
@@ -16,8 +16,10 @@
 package com.google.gwt.requestfactory.client.impl;

 import com.google.gwt.requestfactory.shared.EntityProxy;
+
 import com.google.gwt.requestfactory.shared.EntityProxyChange;
 import com.google.gwt.requestfactory.shared.WriteOperation;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import java.util.Collections;
 import java.util.HashSet;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java Wed Sep 15 03:48:29 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java Wed Sep 15 12:32:43 2010
@@ -44,16 +44,16 @@
 import com.google.gwt.requestfactory.client.impl.AbstractShortRequest;
 import com.google.gwt.requestfactory.client.impl.AbstractStringRequest;
 import com.google.gwt.requestfactory.client.impl.AbstractVoidRequest;
-import com.google.gwt.requestfactory.client.impl.EnumProperty;
 import com.google.gwt.requestfactory.client.impl.FindRequest;
 import com.google.gwt.requestfactory.client.impl.FindRequestObjectImpl;
-import com.google.gwt.requestfactory.client.impl.Property;
 import com.google.gwt.requestfactory.client.impl.ProxyImpl;
 import com.google.gwt.requestfactory.client.impl.ProxyJsoImpl;
 import com.google.gwt.requestfactory.client.impl.ProxySchema;
 import com.google.gwt.requestfactory.client.impl.ProxyToTypeMap;
 import com.google.gwt.requestfactory.client.impl.RequestFactoryJsonImpl;
import com.google.gwt.requestfactory.server.ReflectionBasedOperationRegistry;
+import com.google.gwt.requestfactory.shared.impl.EnumProperty;
+import com.google.gwt.requestfactory.shared.impl.Property;
 import com.google.gwt.requestfactory.shared.EntityProxy;
 import com.google.gwt.requestfactory.shared.EntityProxyId;
 import com.google.gwt.requestfactory.shared.ProxyListRequest;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java Wed Sep 15 03:48:29 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java Wed Sep 15 12:32:43 2010
@@ -15,12 +15,12 @@
  */
 package com.google.gwt.requestfactory.server;

-import com.google.gwt.requestfactory.client.impl.Property;
 import com.google.gwt.requestfactory.shared.EntityProxy;
 import com.google.gwt.requestfactory.shared.EntityProxyId;
 import com.google.gwt.requestfactory.shared.ProxyFor;
 import com.google.gwt.requestfactory.shared.RequestData;
 import com.google.gwt.requestfactory.shared.WriteOperation;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import org.json.JSONArray;
 import org.json.JSONException;
=======================================
--- /trunk/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java Wed Sep 15 02:26:39 2010 +++ /trunk/user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java Wed Sep 15 12:32:43 2010
@@ -38,11 +38,11 @@
 import com.google.gwt.editor.client.adapters.SimpleEditor;
 import com.google.gwt.event.shared.EventBus;
 import com.google.gwt.requestfactory.client.RequestFactoryEditorDriver;
-import com.google.gwt.requestfactory.client.impl.Property;
 import com.google.gwt.requestfactory.shared.EntityProxy;
 import com.google.gwt.requestfactory.shared.RequestFactory;
 import com.google.gwt.requestfactory.shared.RequestObject;
 import com.google.gwt.requestfactory.shared.Violation;
+import com.google.gwt.requestfactory.shared.impl.Property;
 import com.google.gwt.user.client.TakesValue;
 import com.google.gwt.user.client.ui.HasText;

=======================================
--- /trunk/user/test/com/google/gwt/requestfactory/client/impl/SimpleBazProxyImpl.java Tue Sep 14 17:54:04 2010 +++ /trunk/user/test/com/google/gwt/requestfactory/client/impl/SimpleBazProxyImpl.java Wed Sep 15 12:32:43 2010
@@ -16,6 +16,7 @@
 package com.google.gwt.requestfactory.client.impl;

 import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import java.util.Collections;
 import java.util.HashSet;
=======================================
--- /trunk/user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java Tue Sep 14 17:54:04 2010 +++ /trunk/user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java Wed Sep 15 12:32:43 2010
@@ -18,6 +18,8 @@
 import com.google.gwt.requestfactory.shared.SimpleBarProxy;
 import com.google.gwt.requestfactory.shared.SimpleEnum;
 import com.google.gwt.requestfactory.shared.SimpleFooProxy;
+import com.google.gwt.requestfactory.shared.impl.EnumProperty;
+import com.google.gwt.requestfactory.shared.impl.Property;

 import java.math.BigDecimal;
 import java.math.BigInteger;

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to