LGTM On Wed, Sep 15, 2010 at 11:23 AM, <[email protected]> wrote:
> Reviewers: rjrjr, > > Description: > Make key provider a constructor argument to Cell widgets and selection > models > Attempt to fix an IndexOutOfBounds and ClassCast exception in > ExpenseDetails.java > > > Please review this at http://gwt-code-reviews.appspot.com/885801/show > > Affected files: > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseList.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportList.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java > M samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ContactTreeViewModel.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellBrowser.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellList.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellSampler.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTree.java > M > samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellValidation.java > M user/src/com/google/gwt/app/place/AbstractProxyListActivity.java > M user/src/com/google/gwt/requestfactory/RequestFactory.gwt.xml > M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java > M user/src/com/google/gwt/user/cellview/client/CellBrowser.java > M user/src/com/google/gwt/user/cellview/client/CellList.java > M user/src/com/google/gwt/user/cellview/client/CellTable.java > M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java > M user/src/com/google/gwt/user/cellview/client/Column.java > M user/src/com/google/gwt/user/client/ui/ValuePicker.java > M user/src/com/google/gwt/view/client/AbstractDataProvider.java > M user/src/com/google/gwt/view/client/AsyncDataProvider.java > M user/src/com/google/gwt/view/client/DefaultSelectionModel.java > M user/src/com/google/gwt/view/client/HasKeyProvider.java > M user/src/com/google/gwt/view/client/ListDataProvider.java > M user/src/com/google/gwt/view/client/MultiSelectionModel.java > M user/src/com/google/gwt/view/client/NoSelectionModel.java > M user/src/com/google/gwt/view/client/SelectionModel.java > M user/src/com/google/gwt/view/client/SingleSelectionModel.java > M user/test/com/google/gwt/user/cellview/client/HasDataPresenterTest.java > M user/test/com/google/gwt/view/client/AbstractDataProviderTest.java > M user/test/com/google/gwt/view/client/AbstractSelectionModelTest.java > M user/test/com/google/gwt/view/client/AsyncDataProviderTest.java > M user/test/com/google/gwt/view/client/DefaultNodeInfoTest.java > M user/test/com/google/gwt/view/client/DefaultSelectionModelTest.java > M user/test/com/google/gwt/view/client/MockSelectionModel.java > M user/test/com/google/gwt/view/client/MultiSelectionModelTest.java > M user/test/com/google/gwt/view/client/NoSelectionModelTest.java > M user/test/com/google/gwt/view/client/SingleSelectionModelTest.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
