Revision: 8796
Author: [email protected]
Date: Thu Sep 16 08:13:28 2010
Log: Fix warnings and checkstyle errors
Review at http://gwt-code-reviews.appspot.com/882802
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=8796
Modified:
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java
/trunk/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
/trunk/user/src/com/google/gwt/app/place/AbstractProxyListView.java
/trunk/user/src/com/google/gwt/app/place/WithTokenizers.java
/trunk/user/src/com/google/gwt/cell/client/IconCellDecorator.java
/trunk/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
/trunk/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java
/trunk/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java
/trunk/user/src/com/google/gwt/requestfactory/shared/RequestObject.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
/trunk/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
/trunk/user/src/com/google/gwt/user/client/ui/HTML.java
/trunk/user/src/com/google/gwt/user/client/ui/HasOneWidget.java
/trunk/user/src/com/google/gwt/user/client/ui/IsWidget.java
/trunk/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java
/trunk/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
/trunk/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java
/trunk/user/src/com/google/gwt/validation/client/impl/NodeImpl.java
/trunk/user/src/com/google/gwt/validation/rebind/AbstractCreator.java
/trunk/user/test/com/google/gwt/app/place/ActivityManagerTest.java
/trunk/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java
/trunk/user/test/com/google/gwt/validation/client/SimpleSample.java
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBooleanTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByteTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfCharTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDoubleTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloatTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfIntTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLongTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObjectTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShortTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForCollectionTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForMapTest.java
/trunk/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForStringTest.java
/trunk/user/test/com/google/gwt/validation/example/client/Author.java
/trunk/user/test/com/google/gwt/validation/example/client/FirstLevelCheck.java
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java
Fri Sep 10 17:56:09 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java
Thu Sep 16 08:13:28 2010
@@ -161,6 +161,7 @@
// Add a login widget to the page
final LoginWidget login = shell.getLoginWidget();
Receiver<UserInformationProxy> receiver = new
Receiver<UserInformationProxy>() {
+ @Override
public void onSuccess(UserInformationProxy userInformationRecord,
Set<SyncResult> syncResults) {
login.setUserInformation(userInformationRecord);
}
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java
Tue Sep 14 17:54:04 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java
Thu Sep 16 04:46:26 2010
@@ -103,6 +103,7 @@
requestFactory.employeeRequest().findEmployee(employeeId).fire(
new Receiver<EmployeeProxy>() {
+ @Override
public void onSuccess(EmployeeProxy employee,
Set<SyncResult> syncResults) {
final ExpensesMobileShell shell = new
ExpensesMobileShell(eventBus,
@@ -115,6 +116,7 @@
// Add a login widget to the page
final LoginWidget login = shell.getLoginWidget();
Receiver<UserInformationProxy> receiver = new
Receiver<UserInformationProxy>() {
+ @Override
public void onSuccess(UserInformationProxy
userInformationRecord,
Set<SyncResult> syncResults) {
login.setUserInformation(userInformationRecord);
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java
Tue Sep 14 17:54:04 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java
Thu Sep 16 04:46:26 2010
@@ -79,6 +79,7 @@
initWidget(BINDER.createAndBindUi(this));
}
+ @Override
public Widget asWidget() {
return this;
}
@@ -109,6 +110,7 @@
public void onRefresh(boolean clear) {
requestFactory.expenseRequest().findExpense(expense.getId()).fire(
new Receiver<List<ExpenseProxy>>() {
+ @Override
public void onSuccess(List<ExpenseProxy> response,
Set<SyncResult> syncResults) {
assert response.size() == 1;
show(response.get(0));
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
Tue Sep 14 09:37:36 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
Thu Sep 16 04:46:26 2010
@@ -69,6 +69,7 @@
populateList(dateDay, 1, 31);
}
+ @Override
public Widget asWidget() {
return this;
}
@@ -121,6 +122,7 @@
// TODO: wait throbber
requestObject.fire(new Receiver<Void>() {
+ @Override
public void onSuccess(Void ignore, Set<SyncResult> response) {
// Check for commit errors.
String errorMessage = "";
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
Tue Sep 14 09:37:36 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
Thu Sep 16 04:46:26 2010
@@ -78,6 +78,7 @@
populateList(dateDay, 1, 31);
}
+ @Override
public Widget asWidget() {
return this;
}
@@ -123,6 +124,7 @@
// TODO: wait throbber
requestObject.fire(new Receiver<Void>() {
+ @Override
public void onSuccess(Void ignore, Set<SyncResult> response) {
// Check for commit errors.
String errorMessage = "";
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java
Tue Sep 14 17:54:04 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java
Thu Sep 16 04:46:26 2010
@@ -15,9 +15,8 @@
*/
package com.google.gwt.sample.expenses.client.request;
-import com.google.gwt.requestfactory.shared.ProxyFor;
-
import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.ProxyFor;
import java.util.Date;
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java
Thu Sep 2 20:54:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java
Thu Sep 16 04:46:26 2010
@@ -64,6 +64,7 @@
initWidget(BINDER.createAndBindUi(this));
}
+ @Override
public Widget asWidget() {
return this;
}
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java
Thu Sep 2 20:54:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java
Thu Sep 16 04:46:26 2010
@@ -84,6 +84,7 @@
DATA_BINDER.init(this);
}
+ @Override
public EmployeeEditView asWidget() {
return this;
}
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java
Thu Sep 2 20:54:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java
Thu Sep 16 04:46:26 2010
@@ -67,6 +67,7 @@
initWidget(BINDER.createAndBindUi(this));
}
+ @Override
public Widget asWidget() {
return this;
}
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java
Thu Sep 2 20:54:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java
Thu Sep 16 04:46:26 2010
@@ -77,6 +77,7 @@
DATA_BINDER.init(this);
}
+ @Override
public ReportEditView asWidget() {
return this;
}
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java
Wed Aug 18 18:29:03 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java
Thu Sep 16 04:46:26 2010
@@ -359,7 +359,7 @@
"Met with COMPANY in CITY", "Met w/ COMPANY in CITY",
"Met COMPANY in CITY with FULLNAME",
"Met with COMPANY in FULLCITY with FIRSTNAME", "COMPANY lunch",
- "Conference", "Sales opportunity", "Sales opprtunity with COMPANY",
+ "Conference", "Sales opportunity", "Sales opportunity with COMPANY",
"Maintenance", "Supplies", "Emergency", "Backup", "Research",
"CITY breakfast", "CITY lunch", "CITY dinner", "CITY conference",
"Conference in CITY", "Conference in FULLCITY", "Meals with
FIRSTNAME",
=======================================
--- /trunk/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
Tue Sep 14 17:54:04 2010
+++ /trunk/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
Thu Sep 16 04:46:26 2010
@@ -117,6 +117,7 @@
requestObject = null;
Receiver<Void> receiver = new Receiver<Void>() {
+ @Override
public void onSuccess(Void ignore, Set<SyncResult> response) {
// TODO(rjrjr): This can be simplified with
RequestFactory.refresh()
if (display == null) {
@@ -169,6 +170,7 @@
} else {
ProxyRequest<P> findRequest = getFindRequest(getRecord().getId());
findRequest.with(getView().getPaths()).fire(new Receiver<P>() {
+ @Override
public void onSuccess(P record, Set<SyncResult> syncResults) {
if (AbstractProxyEditActivity.this.display != null) {
doStart(AbstractProxyEditActivity.this.display, record);
=======================================
--- /trunk/user/src/com/google/gwt/app/place/AbstractProxyListView.java Thu
Sep 2 20:54:55 2010
+++ /trunk/user/src/com/google/gwt/app/place/AbstractProxyListView.java Thu
Sep 16 04:46:26 2010
@@ -52,6 +52,7 @@
return table;
}
+ @Override
public AbstractProxyListView<P> asWidget() {
return this;
}
=======================================
--- /trunk/user/src/com/google/gwt/app/place/WithTokenizers.java Mon Aug 16
20:22:31 2010
+++ /trunk/user/src/com/google/gwt/app/place/WithTokenizers.java Thu Sep 16
04:46:26 2010
@@ -25,7 +25,7 @@
* {...@link PlaceHistoryHandler} generated by
* {...@link com.google.gwt.app.rebind.PlaceHistoryHandlerGenerator}.
*/
-...@target( {ElementType.TYPE})
+...@target({ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
public @interface WithTokenizers {
Class<? extends PlaceTokenizer<?>>[] value();
=======================================
--- /trunk/user/src/com/google/gwt/cell/client/IconCellDecorator.java Thu
Sep 2 08:33:16 2010
+++ /trunk/user/src/com/google/gwt/cell/client/IconCellDecorator.java Thu
Sep 16 04:46:26 2010
@@ -163,11 +163,13 @@
String vert = valign == HasVerticalAlignment.ALIGN_MIDDLE ? "center"
: valign.getVerticalAlignString();
// Templates are having problems with
url('data:image/png;base64,...')
+ // CHECKSTYLE_OFF
return SafeHtmlUtils.fromTrustedString("<div
style=\"position:absolute;"
+ direction + ":0px;top:0px;height:100%;width:" + res.getWidth()
+ "px;background:url('" + res.getURL() + "') no-repeat scroll "
+ SafeHtmlUtils.htmlEscape(vert) // for safety
+ " center transparent;\"></div>");
+ // CHECKSTYLE_ON
}
}
=======================================
---
/trunk/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
Wed Sep 15 02:26:39 2010
+++
/trunk/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
Thu Sep 16 04:46:26 2010
@@ -46,6 +46,7 @@
* {...@link com.google.gwt.editor.client.EditorError#getUserData()
* EditorError.getUserData()}.
*/
+ @Override
public T getValue() {
try {
value = peer.getValueOrThrow();
@@ -57,6 +58,7 @@
return value;
}
+ @Override
public void setValue(T value) {
peer.setValue(this.value = value);
}
=======================================
--- /trunk/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java
Fri Sep 10 12:29:13 2010
+++ /trunk/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java
Thu Sep 16 04:46:26 2010
@@ -112,6 +112,7 @@
/**
* For debugging use only.
*/
+ @Override
public String toString() {
return path + " = " + type.getParameterizedQualifiedSourceName();
}
=======================================
---
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
Wed Sep 15 17:53:58 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
Thu Sep 16 04:46:26 2010
@@ -34,13 +34,14 @@
public class RequestFactoryLogHandler extends Handler {
/**
- * Provides a logging request
+ * Provides a logging request.
*/
public static interface LoggingRequestProvider {
LoggingRequest getLoggingRequest();
}
private class LoggingReceiver extends Receiver<Long> {
+ @Override
public void onSuccess(Long response, Set<SyncResult> syncResults) {
if (response > 0) {
logger.finest("Remote logging successful");
=======================================
---
/trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java
Tue Sep 7 10:09:37 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java
Thu Sep 16 04:46:26 2010
@@ -15,8 +15,6 @@
*/
package com.google.gwt.requestfactory.client.impl;
-
-
/**
* <p>
* <span style="color:red">Experimental API: This class is still under
rapid
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java
Fri Sep 10 17:56:09 2010
+++ /trunk/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java
Thu Sep 16 04:46:26 2010
@@ -56,7 +56,7 @@
/**
* Will only be non-null if this is an event of type {...@link
State#RECEIVED},
- * and the RPC was successful
+ * and the RPC was successful.
*/
private final Response response;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/shared/RequestObject.java
Wed Sep 15 03:48:29 2010
+++ /trunk/user/src/com/google/gwt/requestfactory/shared/RequestObject.java
Thu Sep 16 04:46:26 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.requestfactory.shared;
-
/**
* <p>
* <span style="color:red">Experimental API: This class is still under
rapid
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
Thu Sep 9 08:24:17 2010
+++
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
Thu Sep 16 04:46:26 2010
@@ -39,7 +39,7 @@
private String fieldName;
/**
- * Mapping of child tag to the number of times it has been called
+ * Mapping of child tag to the number of times it has been called.
*/
private Map<String, Integer> numCallsToChildMethod = new HashMap<String,
Integer>();
private Map<String, Pair<JMethod, Integer>> uiChildMethods;
@@ -96,7 +96,7 @@
}
/**
- * Process a child element that should be added using a {...@link UiChild}
method
+ * Process a child element that should be added using a {...@link UiChild}
method.
*/
private void handleChild(XMLElement child) throws
UnableToCompleteException {
String tag = child.getLocalName();
=======================================
---
/trunk/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
Thu Sep 9 08:24:17 2010
+++
/trunk/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
Thu Sep 16 04:46:26 2010
@@ -250,7 +250,7 @@
}
/**
- * Scans the class to find all methods annotated with @UiChild
+ * Scans the class to find all methods annotated with @UiChild.
*
* @param ownerType the type of the owner class
* @throws UnableToCompleteException
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/HTML.java Fri Sep 10
05:47:32 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/HTML.java Thu Sep 16
04:46:26 2010
@@ -136,7 +136,6 @@
public void setHTML(String html) {
setTextOrHtml(html, true);
}
-
/**
* Sets the label's content to the given HTML, applying the given
direction.
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/HasOneWidget.java Mon Sep
13 10:28:49 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/HasOneWidget.java Thu Sep
16 04:46:26 2010
@@ -27,12 +27,12 @@
*
* @return the child widget, or <code>null</code> if none is present
*/
- public Widget getWidget();
+ Widget getWidget();
/**
* Sets this panel's widget. Any existing child widget will be removed.
*
* @param w the panel's new widget, or <code>null</code> to clear the
panel
*/
- public void setWidget(Widget w);
-}
+ void setWidget(Widget w);
+}
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/IsWidget.java Mon Sep 13
10:28:49 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/IsWidget.java Thu Sep 16
04:46:26 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.user.client.ui;
-
/**
* Extended by view interfaces that are likely to be implemented by
Widgets.
* Provides access to that widget, if it exists, without compromising the
=======================================
---
/trunk/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java
Thu Sep 16 04:46:26 2010
@@ -22,7 +22,7 @@
import javax.validation.constraints.Past;
/**
- * {...@link Past} constraint validator implementation for a {...@link
java.util.Date}
+ * {...@link Past} constraint validator implementation for a {...@link
java.util.Date}.
*/
public class PastValidatorForDate implements ConstraintValidator<Past,
Date> {
=======================================
---
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java
Fri Sep 3 12:24:52 2010
+++
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java
Thu Sep 16 04:46:26 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.validation.client.impl;
-
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
=======================================
---
/trunk/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
Fri Sep 3 12:24:52 2010
+++
/trunk/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
Thu Sep 16 04:46:26 2010
@@ -33,7 +33,7 @@
ConstraintDescriptor<T> {
/**
- * Builder for {...@link ConstraintDescriptorImpl}
+ * Builder for {...@link ConstraintDescriptorImpl}.
*
* @param <T> the constraint annotation to describe.
*/
@@ -47,7 +47,7 @@
private boolean reportAsSingleViolation;
public ConstraintDescriptorImpl<T> build() {
- return new ConstraintDescriptorImpl<T>( //
+ return new ConstraintDescriptorImpl<T>(
annotation, //
groups, //
payload, //
=======================================
---
/trunk/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java
Fri Sep 3 12:24:52 2010
+++
/trunk/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java
Thu Sep 16 04:46:26 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.validation.client.impl;
-
import java.util.Set;
import javax.validation.ConstraintViolation;
@@ -87,8 +86,8 @@
/**
* Validates all constraints placed on the property named
- * <code>propertyName</code> of the class <code>beanType</code> would the
- * property value be <code>value</code>
+ * <code>propertyName</code> of the class <code>beanType</code> where the
+ * property value is <code>value</code>.
* <p/>
* <code>ConstraintViolation</code> objects return null for
* {...@link ConstraintViolation#getRootBean()} and
=======================================
--- /trunk/user/src/com/google/gwt/validation/client/impl/NodeImpl.java Fri
Sep 3 12:24:52 2010
+++ /trunk/user/src/com/google/gwt/validation/client/impl/NodeImpl.java Thu
Sep 16 04:46:26 2010
@@ -20,7 +20,7 @@
import javax.validation.Path.Node;
/**
- * An immutable GWT safe implementation of {...@link Node}
+ * An immutable GWT safe implementation of {...@link Node}.
*/
class NodeImpl implements Node, Serializable {
=======================================
--- /trunk/user/src/com/google/gwt/validation/rebind/AbstractCreator.java
Wed Sep 8 07:45:57 2010
+++ /trunk/user/src/com/google/gwt/validation/rebind/AbstractCreator.java
Thu Sep 16 04:46:26 2010
@@ -52,7 +52,7 @@
writeClassBody(sourceWriter);
sourceWriter.commit(logger);
}
- return getQaulifiedName();
+ return getQualifiedName();
}
protected abstract void compose(ClassSourceFileComposerFactory
composerFactory);
@@ -65,16 +65,16 @@
protected abstract void writeClassBody(SourceWriter sourceWriter);
- private final String getQaulifiedName() {
+ private String getQualifiedName() {
String packageName = getPackage();
return (packageName == "" ? "" : packageName + ".") + getSimpleName();
}
- private final String getSimpleName() {
+ private String getSimpleName() {
return validatorType.getSimpleSourceName() + "Impl";
}
- private final SourceWriter getSourceWriter(TreeLogger logger,
+ private SourceWriter getSourceWriter(TreeLogger logger,
GeneratorContext ctx) {
String packageName = getPackage();
String simpleName = getSimpleName();
=======================================
--- /trunk/user/test/com/google/gwt/app/place/ActivityManagerTest.java Mon
Sep 13 10:28:49 2010
+++ /trunk/user/test/com/google/gwt/app/place/ActivityManagerTest.java Thu
Sep 16 04:46:26 2010
@@ -26,7 +26,6 @@
import junit.framework.TestCase;
-
/**
* Eponymous unit test.
*/
=======================================
---
/trunk/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java
Mon Aug 16 20:22:31 2010
+++
/trunk/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java
Thu Sep 16 04:46:26 2010
@@ -81,6 +81,7 @@
doTest(subject, factory);
}
+ // CHECKSTYLE_OFF
private void doTest(AbstractPlaceHistoryHandler<?> subject,
TokenizerFactory factory) {
String history1 = subject.getPrefixAndToken(place1).toString();
@@ -91,14 +92,20 @@
assertEquals(TokenizerFactory.PLACE2_PREFIX + ":" + place2.content,
history2);
} else {
+ // CHECKSTYLE_OFF
assertEquals("Place2:" + place2.content, history2);
+ // CHECKSTYLE_ON
}
String history3 = subject.getPrefixAndToken(place3).toString();
+ // CHECKSTYLE_OFF
assertEquals("Place3:" + place3.content, history3);
+ // CHECKSTYLE_ON
String history4 = subject.getPrefixAndToken(place4).toString();
+ // CHECKSTYLE_OFF
assertEquals("Place4:" + place4.content, history4);
+ // CHECKSTYLE_ON
if (factory != null) {
assertEquals(factory.tokenizer,
=======================================
--- /trunk/user/test/com/google/gwt/validation/client/SimpleSample.java Wed
Jul 28 12:08:32 2010
+++ /trunk/user/test/com/google/gwt/validation/client/SimpleSample.java Thu
Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.NotNull;
/**
- * A simple sample class to test javax.validation
+ * A simple sample class to test javax.validation.
*/
public class SimpleSample {
@NotNull
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.DecimalMax;
/**
- * Tests for {...@link DecimalMaxValidatorForNumber}
+ * Tests for {...@link DecimalMaxValidatorForNumber}.
*/
public class DecimalMaxValidatorForNumberTest extends
ConstraintValidatorTestCase<DecimalMax, Number> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.DecimalMax;
/**
- * Tests for {...@link DecimalMaxValidatorForString}
+ * Tests for {...@link DecimalMaxValidatorForString}.
*/
public class DecimalMaxValidatorForStringTest extends
ConstraintValidatorTestCase<DecimalMax, String> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.DecimalMin;
/**
- * Tests for {...@link DecimalMinValidatorForNumber}
+ * Tests for {...@link DecimalMinValidatorForNumber}.
*/
public class DecimalMinValidatorForNumberTest extends
ConstraintValidatorTestCase<DecimalMin, Number> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.DecimalMin;
/**
- * Tests for {...@link DecimalMinValidatorForString}
+ * Tests for {...@link DecimalMinValidatorForString}.
*/
public class DecimalMinValidatorForStringTest extends
ConstraintValidatorTestCase<DecimalMin, String> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java
Thu Sep 16 04:46:26 2010
@@ -20,7 +20,7 @@
import javax.validation.constraints.Digits;
/**
- * Tests for {...@link DigitsValidatorForNumber}
+ * Tests for {...@link DigitsValidatorForNumber}.
*/
public class DigitsValidatorForNumberTest extends
ConstraintValidatorTestCase<Digits, Number> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.Digits;
/**
- * Tests for {...@link DigitsValidatorForString}
+ * Tests for {...@link DigitsValidatorForString}.
*/
public class DigitsValidatorForStringTest extends
ConstraintValidatorTestCase<Digits, String> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java
Thu Sep 16 04:46:26 2010
@@ -20,12 +20,11 @@
import javax.validation.constraints.Future;
/**
- * Tests for {...@link FutureValidatorForDate}
+ * Tests for {...@link FutureValidatorForDate}.
*/
public class FutureValidatorForDateTest extends
ConstraintValidatorTestCase<Future, Date> {
-
@SuppressWarnings("unused")
@Future
private Date defaultField;
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java
Thu Sep 16 04:46:26 2010
@@ -67,6 +67,4 @@
assertEquals(29, temp.size());
}
-
-
-}
+}
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.Max;
/**
- * Tests for {...@link MaxValidatorForNumber}
+ * Tests for {...@link MaxValidatorForNumber}.
*/
public class MaxValidatorForNumberTest extends
ConstraintValidatorTestCase<Max, Number> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.Max;
/**
- * Tests for {...@link MinValidatorForString}
+ * Tests for {...@link MinValidatorForString}.
*/
public class MaxValidatorForStringTest extends
ConstraintValidatorTestCase<Max, String> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.Min;
/**
- * Tests for {...@link MinValidatorForNumber}
+ * Tests for {...@link MinValidatorForNumber}.
*/
public class MinValidatorForNumberTest extends
ConstraintValidatorTestCase<Min, Number> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java
Thu Sep 16 04:46:26 2010
@@ -18,7 +18,7 @@
import javax.validation.constraints.Max;
/**
- * Tests for {...@link MinValidatorForString}
+ * Tests for {...@link MinValidatorForString}.
*/
public class MinValidatorForStringTest extends
ConstraintValidatorTestCase<Max, String> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java
Thu Sep 16 04:46:26 2010
@@ -19,7 +19,7 @@
import javax.validation.constraints.NotNull;
/**
- * Tests for {...@link NotNullValidator}
+ * Tests for {...@link NotNullValidator}.
*/
public class NotNullValidatorTest extends
ConstraintValidatorTestCase<NotNull, Object> {
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java
Thu Sep 16 04:46:26 2010
@@ -20,12 +20,11 @@
import javax.validation.constraints.Past;
/**
- * Tests for {...@link PastValidatorForDate}
+ * Tests for {...@link PastValidatorForDate}.
*/
public class PastValidatorForDateTest extends
ConstraintValidatorTestCase<Past, Date> {
-
@SuppressWarnings("unused")
@Past
private Date defaultField;
=======================================
---
/trunk/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java
Thu Aug 5 13:48:12 2010
+++
/trunk/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java
Thu Sep 16 04:46:26 2010
@@ -20,12 +20,11 @@
import javax.validation.constraints.Pattern;
/**
- * Tests for {...@link PastValidatorForDate}
+ * Tests for {...@link PastValidatorForDate}.
*/
public class PatternValidatorTest extends
ConstraintValidatorTestCase<Pattern, String> {
-
@SuppressWarnings("unused")
@Pattern(regexp = "good")
private Date defaultField;
=======================================
***Additional files exist in this changeset.***
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
