http://gwt-code-reviews.appspot.com/886801/diff/13001/14006 File user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java (right):
http://gwt-code-reviews.appspot.com/886801/diff/13001/14006#newcode70 user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java:70: static class DefaultExceptionHandler implements ExceptionHandler { On 2010/09/16 21:01:20, bobv wrote:
Make this a public, top-level type for end-users to extend in case the ExceptionHandler interface ever needs to grow. Also, add an @see in ExceptionHandler's javadoc to the default implementation.
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14006#newcode76 user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java:76: private ExceptionHandler exceptionHandler; On 2010/09/16 21:01:20, bobv wrote:
final
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14006#newcode87 user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java:87: super(); On 2010/09/16 21:01:20, bobv wrote:
Unnecessary.
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14008 File user/src/com/google/gwt/requestfactory/shared/Receiver.java (right): http://gwt-code-reviews.appspot.com/886801/diff/13001/14008#newcode36 user/src/com/google/gwt/requestfactory/shared/Receiver.java:36: throw new RuntimeException(error.getExceptionType() + ": " On 2010/09/16 21:01:20, bobv wrote:
That's going to look strange when the exception type is an empty
string. Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14009 File user/src/com/google/gwt/requestfactory/shared/ServerFailure.java (right): http://gwt-code-reviews.appspot.com/886801/diff/13001/14009#newcode34 user/src/com/google/gwt/requestfactory/shared/ServerFailure.java:34: String message, String exceptionType, String stackTraceString) { On 2010/09/16 21:01:20, bobv wrote:
Formatting is off.
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14009#newcode36 user/src/com/google/gwt/requestfactory/shared/ServerFailure.java:36: type = exceptionType; On 2010/09/16 21:01:20, bobv wrote:
Inconsistent naming.
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14010 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/886801/diff/13001/14010#newcode450 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:450: assertEquals("Server Error", On 2010/09/16 21:01:20, bobv wrote:
This value is inconsistent with a type name.
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14010#newcode452 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:452: assertEquals("", error.getStackTraceString()); On 2010/09/16 21:01:20, bobv wrote:
Use a test-specific ExceptionHandler that uses a non-empty string to
ensure the
field is being correctly transmitted.
Done. Created separate test that uses a custom RequestFactoryServlet. http://gwt-code-reviews.appspot.com/886801/diff/13001/14010#newcode453 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:453: finishTest(); On 2010/09/16 21:01:20, bobv wrote:
You'll need to sync to head and change this to finishTestAndReset().
Done. http://gwt-code-reviews.appspot.com/886801/diff/13001/14011 File user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java (right): http://gwt-code-reviews.appspot.com/886801/diff/13001/14011#newcode70 user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java:70: static final Property<Integer> pleaseCrash = new Property<Integer>("pleaseCrash", Integer.class); On 2010/09/16 21:01:20, bobv wrote:
Is this actually used anywhere? The Property API has been made
completely
internal to the generated code.
This file is still present after I merged with HEAD. It will have to be removed separately. http://gwt-code-reviews.appspot.com/886801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
