http://gwt-code-reviews.appspot.com/890802/diff/1/2
File
user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
(right):

http://gwt-code-reviews.appspot.com/890802/diff/1/2#newcode98
user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java:98:
builder.setHeader("pageurl", Location.getHref());
On 2010/09/17 18:28:24, rjrjr wrote:
Set the magic permutation header here? Or is that being set elsewhere?

Done.

http://gwt-code-reviews.appspot.com/890802/diff/1/4
File
user/src/com/google/gwt/requestfactory/shared/HasRequestTransport.java
(right):

http://gwt-code-reviews.appspot.com/890802/diff/1/4#newcode20
user/src/com/google/gwt/requestfactory/shared/HasRequestTransport.java:20:
* the manner in which requests are sent to the backend.
On 2010/09/17 18:28:24, rjrjr wrote:
Why do it via cast? Why not just make RequestFactory extend it? Or
make this
part of RF proper?

Perhaps add an overload of RequestFactory#init that accepts an RT?

Done.

http://gwt-code-reviews.appspot.com/890802/diff/1/5
File user/src/com/google/gwt/requestfactory/shared/RequestFactory.java
(right):

http://gwt-code-reviews.appspot.com/890802/diff/1/5#newcode91
user/src/com/google/gwt/requestfactory/shared/RequestFactory.java:91: *
DefaultRequestTransport}.
On 2010/09/17 18:28:24, rjrjr wrote:
This makes me think that if I call init after calling setTransport
I'll clobber
myself.

Done.

http://gwt-code-reviews.appspot.com/890802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to