LGTM.  Nits.  LOL.

http://gwt-code-reviews.appspot.com/904801/diff/5001/6001
File dev/core/src/com/google/gwt/dev/resource/impl/ClassPathEntry.java
(right):

http://gwt-code-reviews.appspot.com/904801/diff/5001/6001#newcode36
dev/core/src/com/google/gwt/dev/resource/impl/ClassPathEntry.java:36:
assert (ret ? getClass().equals(otherCpe.getClass()) : true);
You can just identity compare class objects.

http://gwt-code-reviews.appspot.com/904801/diff/5001/6001#newcode75
dev/core/src/com/google/gwt/dev/resource/impl/ClassPathEntry.java:75: *
ClassPathEntries with teh same location string are considered equal.
This comment is teh lolz!

http://gwt-code-reviews.appspot.com/904801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to