For the untranslatable validators, it seems more straightforward to have
a super-source version of the annotation that's tagged as
@NotGwtCompatible.

Instead of having the sample app import the HibernateValidator package,
would it make sense to have the gwt.Validation package include the
HibernateValidator instead?


http://gwt-code-reviews.appspot.com/863801/diff/3002/15002
File eclipse/samples/Validation/.classpath (right):

http://gwt-code-reviews.appspot.com/863801/diff/3002/15002#newcode5
eclipse/samples/Validation/.classpath:5: <classpathentry kind="src"
path="gwt-gen"/>
Is this left over from debugging?

http://gwt-code-reviews.appspot.com/863801/diff/3002/15016
File
user/src/com/google/gwt/validation/client/constraints/NotGwtCompatibleValidator.java
(right):

http://gwt-code-reviews.appspot.com/863801/diff/3002/15016#newcode25
user/src/com/google/gwt/validation/client/constraints/NotGwtCompatibleValidator.java:25:
* as <strong>NOT GWT COMPATIBLE</strong>.
If the validator weren't GWT-compatible, it couldn't be in the
TypeOracle to begin with.  If you think it's necessary to be able to
exclude a validator, would an inheritable annotation make sense instead?

http://gwt-code-reviews.appspot.com/863801/diff/3002/15019
File
user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
(right):

http://gwt-code-reviews.appspot.com/863801/diff/3002/15019#newcode88
user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java:88:
*/
Empty javadoc.

http://gwt-code-reviews.appspot.com/863801/diff/3002/15022
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/863801/diff/3002/15022#newcode89
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:89:
// TODO handle the rest
Todo?

http://gwt-code-reviews.appspot.com/863801/diff/3002/15022#newcode282
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:282:
sw.print("//GWT.create(");
What's going on here?

http://gwt-code-reviews.appspot.com/863801/diff/3002/15022#newcode487
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:487:
sw.print("//  GWT.create(");
Same construct as above?

http://gwt-code-reviews.appspot.com/863801/diff/3002/15025
File user/src/org/hibernate/validator/HibernateValidator.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/863801/diff/3002/15025#newcode3
user/src/org/hibernate/validator/HibernateValidator.gwt.xml:3: <!DOCTYPE
module PUBLIC "-//Google Inc.//DTD Google Web Toolkit 1.6.4//EN"
"http://google-web-toolkit.googlecode.com/svn/tags/1.6.4/distro-source/core/src/gwt-module.dtd";>
Cut the DTD.

http://gwt-code-reviews.appspot.com/863801/diff/3002/15025#newcode6
user/src/org/hibernate/validator/HibernateValidator.gwt.xml:6: <source
path="constraints">
Indentation is off.

http://gwt-code-reviews.appspot.com/863801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to