LGTM
http://gwt-code-reviews.appspot.com/906801/diff/1/12 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellValidation.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/12#newcode104 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellValidation.java:104: input.getStyle().setColor("blue"); Maybe add a TODO to make this stylable http://gwt-code-reviews.appspot.com/906801/diff/1/13 File user/src/com/google/gwt/cell/client/AbstractCell.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/13#newcode128 user/src/com/google/gwt/cell/client/AbstractCell.java:128: * Called when the user triggers a <code>keydown</code> event with the ENTER key http://gwt-code-reviews.appspot.com/906801/diff/1/14 File user/src/com/google/gwt/cell/client/AbstractEditableCell.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/14#newcode86 user/src/com/google/gwt/cell/client/AbstractEditableCell.java:86: * may chooses to pass keystrokes directly to the cell rather than using them chooses -> choose http://gwt-code-reviews.appspot.com/906801/diff/1/15 File user/src/com/google/gwt/cell/client/AbstractInputCell.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/15#newcode36 user/src/com/google/gwt/cell/client/AbstractInputCell.java:36: private final Set<String> consumedEvents = new HashSet<String>(); AbstractCell already has a final Set<String> consumedEvents http://gwt-code-reviews.appspot.com/906801/diff/1/15#newcode50 user/src/com/google/gwt/cell/client/AbstractInputCell.java:50: super(); Change to super(consumedEvents) and delete the for loop Instead of adding the events in init(), it might be safer to pass the incoming events + {focus,blur,keydown} into super(...) http://gwt-code-reviews.appspot.com/906801/diff/1/15#newcode64 user/src/com/google/gwt/cell/client/AbstractInputCell.java:64: super(); Change to super(consumedEvents) and delete the addAll http://gwt-code-reviews.appspot.com/906801/diff/1/15#newcode70 user/src/com/google/gwt/cell/client/AbstractInputCell.java:70: public Set<String> getConsumedEvents() { Delete, implemented in AbstractCell http://gwt-code-reviews.appspot.com/906801/diff/1/15#newcode144 user/src/com/google/gwt/cell/client/AbstractInputCell.java:144: private void init() { getConsumedEvents().add(...) http://gwt-code-reviews.appspot.com/906801/diff/1/16 File user/src/com/google/gwt/cell/client/ActionCell.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/16#newcode78 user/src/com/google/gwt/cell/client/ActionCell.java:78: onEnterKeyDown(parent, value, key, event, valueUpdater); Perhaps onEnterKeyDown should have a different name if it also useful in this case? http://gwt-code-reviews.appspot.com/906801/diff/1/21 File user/src/com/google/gwt/cell/client/CompositeCell.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/21#newcode151 user/src/com/google/gwt/cell/client/CompositeCell.java:151: // The first child that takes focus ones. One one child should ever be in ones -> wins? http://gwt-code-reviews.appspot.com/906801/diff/1/40 File user/src/com/google/gwt/user/cellview/client/CellTree.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/40#newcode682 user/src/com/google/gwt/user/cellview/client/CellTree.java:682: public void setAccessKey(char key) { Document that -1 means no access key http://gwt-code-reviews.appspot.com/906801/diff/1/40#newcode808 user/src/com/google/gwt/user/cellview/client/CellTree.java:808: if (KeyboardSelectionPolicy.DISABLED == getKeyboardSelectionPolicy()) { Maybe create a method boolean isKeyboardSelectionDisabled() in a suitable superclass? http://gwt-code-reviews.appspot.com/906801/diff/1/45 File user/src/com/google/gwt/user/cellview/client/HasKeyboardSelectionPolicy.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/45#newcode42 user/src/com/google/gwt/user/cellview/client/HasKeyboardSelectionPolicy.java:42: BOUND Maybe BOUND_TO_SELECTION? http://gwt-code-reviews.appspot.com/906801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
