LGTM, with the change that the testServerFailure() in RequestFactoryTest be split into two, as we talked about in person.
On Wed, Sep 22, 2010 at 11:48 AM, <[email protected]> wrote: > Reviewers: amitmanjhi, > > Description: > Some Small logging cleanup > - Use server error reporting in RF > - Some documentation fixes > - Create inherits module for projects using logging classes but not > enabling loggin > > > Please review this at http://gwt-code-reviews.appspot.com/875802/show > > Affected files: > A user/src/com/google/gwt/logging/LoggingDisabled.gwt.xml > M user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java > M user/src/com/google/gwt/requestfactory/RequestFactory.gwt.xml > M > user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java > M user/src/com/google/gwt/requestfactory/server/Logging.java > M user/src/com/google/gwt/requestfactory/shared/LoggingRequest.java > M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java > M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
