http://gwt-code-reviews.appspot.com/883802/diff/1/7 File user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java (right):
http://gwt-code-reviews.appspot.com/883802/diff/1/7#newcode103 user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java:103: private String asJsonString(Object value) { Array values? http://gwt-code-reviews.appspot.com/883802/diff/1/7#newcode108 user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java:108: if (value instanceof Collection) { Iterable? http://gwt-code-reviews.appspot.com/883802/diff/1/7#newcode129 user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java:129: // everything is toString(), except Date and Enum which must become numbers Block comment. http://gwt-code-reviews.appspot.com/883802/diff/1/7#newcode138 user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java:138: return value.toString(); Strings need to be escaped. Add a test that sends the following string literal back and forth: '\\'\\\\'"\\"\\\\" quote backslash quote 2xbackslash quote, repeat with doublequotes. Even better would be to re-use the i18n test from RPCSuite that sends various combinations of high-unicode across the wire. http://gwt-code-reviews.appspot.com/883802/diff/1/9 File user/test/com/google/gwt/requestfactory/server/SimpleFoo.java (right): http://gwt-code-reviews.appspot.com/883802/diff/1/9#newcode350 user/test/com/google/gwt/requestfactory/server/SimpleFoo.java:350: Whitespace. http://gwt-code-reviews.appspot.com/883802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
