http://gwt-code-reviews.appspot.com/912802/diff/1/5 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (right):
http://gwt-code-reviews.appspot.com/912802/diff/1/5#newcode91 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:91: public EntityProxyId<P> getId() { See the use of this method below, I was assuming it would return a string. Can you rename it to getStableId() or getEntityProxyId() ? http://gwt-code-reviews.appspot.com/912802/diff/1/5#newcode142 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:142: public void onViolation(Set<Violation> errors) { Do you need to reset the request at some point to be able to re-issue it by just calling RFED.flush(), or do you reinitialize the RFED? http://gwt-code-reviews.appspot.com/912802/diff/1/14 File user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java (right): http://gwt-code-reviews.appspot.com/912802/diff/1/14#newcode68 user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java:68: * @param the request that will be fired when editing is done This suggests that RFED will fire the Request. the request that will accumulate edits and is returned from {...@link #flush}. http://gwt-code-reviews.appspot.com/912802/diff/1/21 File user/src/com/google/gwt/requestfactory/shared/EntityProxy.java (right): http://gwt-code-reviews.appspot.com/912802/diff/1/21#newcode45 user/src/com/google/gwt/requestfactory/shared/EntityProxy.java:45: * @return . Empty. http://gwt-code-reviews.appspot.com/912802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
