[gwt-contrib] Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

Thu, 23 Sep 2010 10:33:37 -0700 

Reviewers: rice,

Description:
Element.getTabIndex() returns undefined on Safari 3 for non-focusable
elements, including divs, which can cause our tests to hang. This patch
updates Element to return -1 if tabIndex is undefined.  We use a typeof
check instead of the standard this.tabIndex || -1 trick because 0 is a
valid return value for this.tabIndex.  Also fixes
AbstractHasDataTestBase.testSetTabIndex() to skip Safari 3, because divs
are not focusable in Safari 3 and earlier.


Please review this at http://gwt-code-reviews.appspot.com/905802/show

Affected files:
  M user/src/com/google/gwt/dom/client/DOMImpl.java
  M user/src/com/google/gwt/dom/client/DOMImplSafari.java
  M user/src/com/google/gwt/dom/client/Element.java
  M user/src/com/google/gwt/user/cellview/CellView.gwt.xml
M user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java 


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to