LGTM other than some nits below.

http://gwt-code-reviews.appspot.com/878803/diff/1/2
File
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
(right):

http://gwt-code-reviews.appspot.com/878803/diff/1/2#newcode114
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:114:

Nit: public is unnecessary.

http://gwt-code-reviews.appspot.com/878803/diff/1/2#newcode382
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:382:
assertEquals(3, handler.totalEventCount);
Add asserts to the previous 2 onSuccess methods instead of just checking
the final counts?

http://gwt-code-reviews.appspot.com/878803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to