[gwt-contrib] Adding null check to AbstractHasDataTestBase#testSetTabIndex to fix broken tests. I assumed RegE... (issue868802)

[jlabanca]

Reviewers: rice,

Description:
Adding null check to AbstractHasDataTestBase#testSetTabIndex to fix
broken tests. I assumed RegExp.exec() would return an empty MatchResult
if nothing matched, but it actually returns null (as the JavaDoc says).

Please review this at http://gwt-code-reviews.appspot.com/868802/show

Affected files:
  M  
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java


Index:  
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
===================================================================
---  
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java	 
(revision 8863)
+++  
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java	 
(working copy)
@@ -87,7 +87,7 @@
     if (userAgent.contains("Safari")) {
       RegExp versionRegExp = RegExp.compile("Version/[0-3]", "ig");
       MatchResult result = versionRegExp.exec(userAgent);
-      if (result.getGroupCount() > 0) {
+      if (result != null && result.getGroupCount() > 0) {
         return;
       }
     }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors