Revision: 8865
Author: [email protected]
Date: Fri Sep 24 04:03:46 2010
Log: Adding null check to AbstractHasDataTestBase#testSetTabIndex to fix
broken tests. I assumed RegExp.exec() would return an empty MatchResult if
nothing matched, but it actually returns null (as the JavaDoc says).
Review at http://gwt-code-reviews.appspot.com/868802
http://code.google.com/p/google-web-toolkit/source/detail?r=8865
Modified:
/trunk/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
=======================================
---
/trunk/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Thu Sep 23 12:26:00 2010
+++
/trunk/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Fri Sep 24 04:03:46 2010
@@ -87,7 +87,7 @@
if (userAgent.contains("Safari")) {
RegExp versionRegExp = RegExp.compile("Version/[0-3]", "ig");
MatchResult result = versionRegExp.exec(userAgent);
- if (result.getGroupCount() > 0) {
+ if (result != null && result.getGroupCount() > 0) {
return;
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
