LGTM except noted below.

http://gwt-code-reviews.appspot.com/888802/diff/1/22
File
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
(right):

http://gwt-code-reviews.appspot.com/888802/diff/1/22#newcode191
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java:191:
* @param recordToTypeMap
Remove or add the other param as well.

http://gwt-code-reviews.appspot.com/888802/diff/1/24
File
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
(right):

http://gwt-code-reviews.appspot.com/888802/diff/1/24#newcode248
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:248:
System.out.println("proxyImplTypeName = " + proxyImplTypeName);
Remove?

http://gwt-code-reviews.appspot.com/888802/diff/1/25
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/888802/diff/1/25#newcode254
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:254:
parameterType = rType;
Remove?

http://gwt-code-reviews.appspot.com/888802/diff/1/29
File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right):

http://gwt-code-reviews.appspot.com/888802/diff/1/29#newcode584
user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java:584: */
Remove the empty javadoc?

http://gwt-code-reviews.appspot.com/888802/diff/1/30
File
user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java
(right):

http://gwt-code-reviews.appspot.com/888802/diff/1/30#newcode36
user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java:36:
*/
Remove? This looks incorrect.

http://gwt-code-reviews.appspot.com/888802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to