Thanks for the feedback. The new patch incorporates the feedback. On Sun, Sep 26, 2010 at 2:41 PM, <[email protected]> wrote:
> > http://gwt-code-reviews.appspot.com/892802/diff/1/2 > File fixWriteOperationEnum.diff (right): > > http://gwt-code-reviews.appspot.com/892802/diff/1/2#newcode1 > fixWriteOperationEnum.diff:1: diff --git > > a/google3/third_party/java_src/gwt/svn/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java > > b/google3/third_party/java_src/gwt/svn/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java > I doubt you meant to check in this diff file. > > http://gwt-code-reviews.appspot.com/892802/diff/1/4 > File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java > (right): > > http://gwt-code-reviews.appspot.com/892802/diff/1/4#newcode195 > user/src/com/google/gwt/app/place/AbstractProxyListActivity.java:195: > update(event.getDataEvent(), event.getProxyId()); > We didn't talk about a rename for this enum, and this is a terrible > name. Asking an event for its event? > > http://gwt-code-reviews.appspot.com/892802/diff/1/5 > File > > > user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java > (right): > > http://gwt-code-reviews.appspot.com/892802/diff/1/5#newcode256 > > user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java:256: > assert master.records.containsKey(proxyId); > What changed here? > > http://gwt-code-reviews.appspot.com/892802/diff/1/9 > File > > user/src/com/google/gwt/requestfactory/client/impl/ValueStoreJsonImpl.java > (right): > > http://gwt-code-reviews.appspot.com/892802/diff/1/9#newcode94 > > user/src/com/google/gwt/requestfactory/client/impl/ValueStoreJsonImpl.java:94: > if (!isFuture) { > What's going on here? Your patch description doesn't mention fixing any > bugs in what events are posted when, or change the semantics. > > http://gwt-code-reviews.appspot.com/892802/diff/1/15 > File > > > user/test/com/google/gwt/requestfactory/client/RequestFactoryStringTest.java > (right): > > http://gwt-code-reviews.appspot.com/892802/diff/1/15#newcode130 > > user/test/com/google/gwt/requestfactory/client/RequestFactoryStringTest.java:130: > assertEquals(1, handler.updateEventCount); > So we do post both a persist event and an update event on create? Not > saying that's a bad thing, just want to know and want to see it > documented. > > > http://gwt-code-reviews.appspot.com/892802/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
