http://gwt-code-reviews.appspot.com/915802/diff/1/4 File dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java (right):
http://gwt-code-reviews.appspot.com/915802/diff/1/4#newcode119 dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java:119: public void setDraftCompile(boolean draft) { On 2010/09/27 18:55:31, scottb wrote:
Should this be killed (and the getter)? We usually make these options
classed
simple POJOs with no 'derived' state. Any you already killed OptionDraftCompile.
Done. http://gwt-code-reviews.appspot.com/915802/diff/1/5 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/915802/diff/1/5#newcode686 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:686: protected static void optimizeJs(JsProgram jsProgram, int optimizationLevel) throws InterruptedException { On 2010/09/27 18:55:31, scottb wrote:
Might as well spec this as (JJSOptions,JsProgram) to match the Java
optimize
loop and make way for future options.
Done. http://gwt-code-reviews.appspot.com/915802/diff/1/6 File dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDraftCompile.java (left): http://gwt-code-reviews.appspot.com/915802/diff/1/6#oldcode46 dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDraftCompile.java:46: optimizeOption.setAggressivelyOptimize(false); On 2010/09/27 18:55:31, scottb wrote:
This used to explicitly turn OFF aggressive optimizations, but I don't
think it
does anymore. Is the change in behavior intentional?
reverted the behavior Originally, my patch turned off aggressive optimizations at levels < 6, but then I changed it to make the aggressively optimize option orthogonal. http://gwt-code-reviews.appspot.com/915802/diff/1/6 File dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDraftCompile.java (right): http://gwt-code-reviews.appspot.com/915802/diff/1/6#newcode27 dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDraftCompile.java:27: public <T extends OptionOptimize> ArgHandlerDraftCompile(T option) { On 2010/09/27 18:55:31, scottb wrote:
No need to templatize anymore, it was just to force two interfaces
into one
parameter.
Turns out we still need it to turn off the aggressive optimizations flag. http://gwt-code-reviews.appspot.com/915802/diff/1/9 File dev/core/src/com/google/gwt/dev/util/arg/OptionOptimize.java (right): http://gwt-code-reviews.appspot.com/915802/diff/1/9#newcode28 dev/core/src/com/google/gwt/dev/util/arg/OptionOptimize.java:28: boolean isDraftCompile(); On 2010/09/27 18:55:31, scottb wrote:
Any real need for this?
no, equivalent to getOptimizationLevel() and test for == OPTIMIZE_LEVEL_DRAFT http://gwt-code-reviews.appspot.com/915802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
