Scott, >From what I can tell, is the last reference to JModVisitor.madeChanges(), maybe we should remove that method.
On Wed, Sep 29, 2010 at 6:17 PM, <[email protected]> wrote: > Reviewers: zundel, > > Description: > The real AST isn't being mutated here, that happens a few lines below. > > Please review this at http://gwt-code-reviews.appspot.com/934801/show > > Affected files: > M dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java > > > Index: dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java > diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java > b/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java > index > a74526e02494d58264952c640fa02187a894e0da..edb12572ba8660e014b1d42e05d53b5e09365e83 > 100644 > --- a/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java > +++ b/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java > @@ -371,7 +371,6 @@ public class MethodInliner { > // Replace all params in the target expression with the actual > arguments. > ParameterReplacer replacer = new ParameterReplacer(x); > replacer.accept(targetExpr); > - madeChanges(replacer.getNumMods()); > > multi.exprs.add(targetExpr); > replaceWithMulti(ctx, multi); > > > -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
