Reviewers: rice,

Description:
Fix the hack in RequestFactoryGenerator.

Patch by: amitmanjhi
Review by: rice

Please review this at http://gwt-code-reviews.appspot.com/935801/show

Affected files:
M user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java


Index: user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
===================================================================
--- user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (revision 8897) +++ user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (working copy)
@@ -238,14 +238,12 @@
     if (!publicProxyType.isAssignableTo(entityProxyType)) {
       return;
     }
+    if (publicProxyType.isTypeParameter() != null) {
+      return;
+    }
     if (generatedProxyTypes.contains(publicProxyType)) {
       return;
     }
-    // Hack
-    if ("P".equals(publicProxyType.getName())) {
-      return;
-    }
-
     String packageName = publicProxyType.getPackage().getName();

     String proxyImplTypeName = publicProxyType.getName() + "Impl";


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to