LGTM

http://gwt-code-reviews.appspot.com/945801/diff/1/2
File
user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java
(right):

http://gwt-code-reviews.appspot.com/945801/diff/1/2#newcode279
user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java:279:
return;
Good catch, though this change has been obviated by the overhaul.

http://gwt-code-reviews.appspot.com/945801/diff/1/3
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/945801/diff/1/3#newcode1074
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1074:
// that will protected against ConcurrentModificationExceptions.
Use a block comment here so eclipse will reflow the text.

http://gwt-code-reviews.appspot.com/945801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to