Revision: 8923
Author: [email protected]
Date: Sun Oct 3 08:42:48 2010
Log: Public ([email protected]):
These annotations allow us use HorizontalSplitPanel, VerticalSplitPanel and
NamedFrame in UiBinder.
http://gwt-code-reviews.appspot.com/865801
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=8923
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/NamedFrame.java
/trunk/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
/trunk/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
/trunk/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/NamedFrame.java Tue Sep
21 07:53:19 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/NamedFrame.java Sun Oct
3 08:42:48 2010
@@ -18,6 +18,7 @@
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.dom.client.IFrameElement;
+import com.google.gwt.uibinder.client.UiConstructor;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Element;
@@ -92,6 +93,7 @@
*
* @throws IllegalArgumentException if the supplied name is not allowed
*/
+ @UiConstructor
public NamedFrame(String name) {
// Setting a src prevents mixed-content warnings.
//
http://weblogs.asp.net/bleroy/archive/2005/08/09/how-to-put-a-div-over-a-select-in-ie.aspx
=======================================
--- /trunk/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
Fri Aug 20 04:44:06 2010
+++ /trunk/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
Sun Oct 3 08:42:48 2010
@@ -33,6 +33,7 @@
import com.google.gwt.user.client.ui.HTMLPanel;
import com.google.gwt.user.client.ui.Image;
import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.NamedFrame;
import com.google.gwt.user.client.ui.RadioButton;
import com.google.gwt.user.client.ui.StackPanel;
import com.google.gwt.user.client.ui.Widget;
@@ -462,6 +463,11 @@
// assertEquals("Widget has top", 20, p.getWidgetTop(w));
// }
}
+
+ public void testNamedFrame() {
+ NamedFrame p = widgetUi.myNamedFrame;
+ assertNotNull("NamedFrame exists", p);
+ }
public void testStringAttributeIgnoresStaticSetter() {
// Assumes setPopupText() is overloaded such that there is a static
=======================================
--- /trunk/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
Thu Jul 29 11:09:15 2010
+++ /trunk/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
Sun Oct 3 08:42:48 2010
@@ -43,6 +43,7 @@
import com.google.gwt.user.client.ui.ListBox;
import com.google.gwt.user.client.ui.MenuBar;
import com.google.gwt.user.client.ui.MenuItem;
+import com.google.gwt.user.client.ui.NamedFrame;
import com.google.gwt.user.client.ui.PushButton;
import com.google.gwt.user.client.ui.RadioButton;
import com.google.gwt.user.client.ui.StackPanel;
@@ -167,6 +168,7 @@
@UiField Widget myAbsolutePanelItemA;
@UiField Widget myAbsolutePanelItemB;
@UiField Widget myAbsolutePanelItemC;
+ @UiField NamedFrame myNamedFrame;
public WidgetBasedUi() {
external.style().ensureInjected();
=======================================
---
/trunk/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
Fri Aug 20 04:44:06 2010
+++
/trunk/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
Sun Oct 3 08:42:48 2010
@@ -638,6 +638,8 @@
</gwt:at>
</gwt:AbsolutePanel>
+ <gwt:NamedFrame ui:field='myNamedFrame' name='myName'/>
+
</gwt:HTMLPanel>
</gwt:Dock>
</gwt:DockPanel>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
