http://gwt-code-reviews.appspot.com/956801/diff/1/5 File user/test/com/google/gwt/requestfactory/server/SimpleFoo.java (right):
http://gwt-code-reviews.appspot.com/956801/diff/1/5#newcode70 user/test/com/google/gwt/requestfactory/server/SimpleFoo.java:70: return foo; Can you make a copy of this test that also sets up foo2 pointing back to foo? I would like to make sure that cycles through collections don't introduce aliasing or cause meltdowns. http://gwt-code-reviews.appspot.com/956801/diff/4001/5001 File user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestContext.java (right): http://gwt-code-reviews.appspot.com/956801/diff/4001/5001#newcode198 user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestContext.java:198: <Q extends EntityProxy> AutoBean<Q> getSeenOrCreateStub(SimpleEntityProxyId<Q> id) { This method has to return the object that will eventually have the deltas applied to it. The way it's written now, if an object passed in as a arg (thus putting it into seenProxies) is referenced before the deltas are applied, there will be aliasing. I think that the else block needs to return edit(proxy); because calling edit on an object already owned by the context should be idempotent. http://gwt-code-reviews.appspot.com/956801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
