Just to reiterate: please make sure that this fix lands with the test that
it fixes.

On Thu, Sep 30, 2010 at 10:45 AM, <cromwell...@google.com> wrote:

> Reviewers: rjrjr, robertvawter,
>
> Description:
> Fix asJsonString() to properly encode nulls
>
>
> Please review this at http://gwt-code-reviews.appspot.com/932802/show
>
> Affected files:
>  M user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java
>
>
> Index: user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java
> ===================================================================
> --- user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java
> (revision 8902)
> +++ user/src/com/google/gwt/requestfactory/shared/impl/RequestData.java
> (working copy)
> @@ -127,7 +127,7 @@
>
>   private String asJsonString(Object value) {
>     if (value == null) {
> -      return "null";
> +      return null;
>     }
>
>     if (value instanceof Iterable<?>) {
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to