Submitting.
http://gwt-code-reviews.appspot.com/946802/diff/1/3 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (right): http://gwt-code-reviews.appspot.com/946802/diff/1/3#newcode83 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:83: setWaiting(true); There was such an assert, but it's never fired. And it doesn't seem like it would be any more informative than the NPE that would happen on the next line. On 2010/10/03 23:31:12, cromwellian wrote:
Is it possible for saveClicked() to be invoked when editorDriver is
null? In
theory it shouldn't be possible of onStop() is called after the widget
that
generates saveClicked() is disabled, but I wondering if it is possible
to 'queue
up' an event by double clicking the save button rapidly. I guess don't
worry
about it for now (could throw in an assert editorDriver != null), just
looking
to catch eisenbugsā„
http://gwt-code-reviews.appspot.com/946802/diff/1/12 File user/src/com/google/gwt/app/place/ProxyPlace.java (right): http://gwt-code-reviews.appspot.com/946802/diff/1/12#newcode46 user/src/com/google/gwt/app/place/ProxyPlace.java:46: String bits[] = token.split("!"); On 2010/10/03 23:31:12, cromwellian wrote:
Maybe make "!" a constant?
Done. http://gwt-code-reviews.appspot.com/946802/diff/1/20 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/946802/diff/1/20#newcode250 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:250: public void disabled_testChangedEdit() { Removing this, since it will be added by http://gwt-code-reviews.appspot.com/931803 http://gwt-code-reviews.appspot.com/946802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
