Reviewers: cromwellian,

Description:
Fix exit on cancel from create activity. Wasn't going to a
new place, so you couldn't try to create again.


Please review this at http://gwt-code-reviews.appspot.com/950801/show

Affected files:
  M user/src/com/google/gwt/app/place/CreateAndEditProxy.java


Index: user/src/com/google/gwt/app/place/CreateAndEditProxy.java
===================================================================
--- user/src/com/google/gwt/app/place/CreateAndEditProxy.java (revision 8928)
+++ user/src/com/google/gwt/app/place/CreateAndEditProxy.java   (working copy)
@@ -27,18 +27,20 @@
  */
public abstract class CreateAndEditProxy<P extends EntityProxy> extends AbstractProxyEditActivity<P> {

-  private AcceptsOneWidget display;
   private final P proxy;
+  private final PlaceController placeController;
+  private Class<P> proxyClass;

   public CreateAndEditProxy(Class<P> proxyClass, RequestContext request,
       ProxyEditView<P, ?> view, PlaceController placeController) {
     super(view, placeController);
     this.proxy = request.create(proxyClass);
+    this.placeController = placeController;
+    this.proxyClass = proxyClass;
   }

   @Override
   public void start(AcceptsOneWidget display, EventBus eventBus) {
-    this.display = display;
     super.start(display, eventBus);
   }

@@ -51,10 +53,10 @@
   @Override
   protected void exit(boolean saved) {
     if (!saved) {
-      display.setWidget(null);
+      placeController.goTo(new ProxyListPlace(proxyClass));
+    } else {
+      super.exit(saved);
     }
-
-    super.exit(saved);
   }

   @Override


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to