LGTM with the following changes.

We need a follow up that makes Foo and Bar more realistic, s.t. the
counter is incremented only when they actually change. You might use
AutoBean to simplify that.


http://gwt-code-reviews.appspot.com/930802/diff/1/3
File
user/test/com/google/gwt/requestfactory/client/RequestFactoryStringTest.java
(right):

http://gwt-code-reviews.appspot.com/930802/diff/1/3#newcode167
user/test/com/google/gwt/requestfactory/client/RequestFactoryStringTest.java:167:
public void testDummyEdit() {
Dummy isn't a very descriptive name. How about testFindFindEdit()

http://gwt-code-reviews.appspot.com/930802/diff/1/4
File
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
(right):

http://gwt-code-reviews.appspot.com/930802/diff/1/4#newcode364
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:364:
public void testDummyEdit() {
testFindFindEdit

http://gwt-code-reviews.appspot.com/930802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to