http://gwt-code-reviews.appspot.com/955801/diff/1/2
File user/javadoc/com/google/gwt/examples/cell/CellExample.java (right):

http://gwt-code-reviews.appspot.com/955801/diff/1/2#newcode77
user/javadoc/com/google/gwt/examples/cell/CellExample.java:77:
super("click", "keydown");
On 2010/10/05 15:35:31, jlabanca wrote:
Which class would it take?  ClickEvent is a GWT logical wrapper around
the
native click event, and we don't want to tie Cells to the event
system.  We have
a TODO to enumerate the event types so you could use something like
EventType.CLICK instead of having to spell it out every time.

So then would AbstractCell be tied to an EventType enum? Or would you
still be using String? I like the enum idea, I just don't like magic
strings.

I was thinking something along these lines:
http://gist.github.com/611778. However, since Cell is using NativeEvent,
that implementation doesn't make sense (it's also ugly).

http://gwt-code-reviews.appspot.com/955801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to