LGTM
http://gwt-code-reviews.appspot.com/954801/diff/1/19 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java (left): http://gwt-code-reviews.appspot.com/954801/diff/1/19#oldcode46 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java:46: import com.google.gwt.requestfactory.shared.Request; Doesn't have to be done for this change, but we should figure out why as unused imports should trigger a checkstyle failure. http://gwt-code-reviews.appspot.com/954801/diff/1/21 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java (right): http://gwt-code-reviews.appspot.com/954801/diff/1/21#newcode61 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java:61: private final Listener listener; On 2010/10/05 20:11:46, rice wrote:
I think it might be used by generated code but I'm not sure about
that. If it is private, how could it? Or are you suggesting generated JSNI code could be using it? http://gwt-code-reviews.appspot.com/954801/diff/1/32 File user/src/com/google/gwt/app/place/Prefix.java (right): http://gwt-code-reviews.appspot.com/954801/diff/1/32#newcode27 user/src/com/google/gwt/app/place/Prefix.java:27: * {code com.google.gwt.app.rebind.PlaceHistoryMapperGenerator} looks On 2010/10/05 20:11:46, rice wrote:
Will link and include destination class
Sorry, didn't notice it was a rebind class that we plan to exclude from Javadoc. It is fine as-is. http://gwt-code-reviews.appspot.com/954801/diff/1/50 File user/src/com/google/gwt/logging/client/HtmlLogFormatter.java (right): http://gwt-code-reviews.appspot.com/954801/diff/1/50#newcode62 user/src/com/google/gwt/logging/client/HtmlLogFormatter.java:62: * @param event On 2010/10/05 20:11:46, rice wrote:
My scheme is more or less as follows:
If the unused param occurs in 'frameworky' code, where we expect there
to be
subclasses that make use of the param, javadoc it
If the method occurs in code that is unlikely to be further subclassed
(but
isn't one of the situations where checking the box in Eclipse will
remove the
warning, such as can happen with UiBinder), use @SuppressWarnings
Ok. http://gwt-code-reviews.appspot.com/954801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
