Revision: 8957
Author: [email protected]
Date: Wed Oct  6 09:35:36 2010
Log: Avoid an infinite loop in toString() for collections that directly include themselves

Review at http://gwt-code-reviews.appspot.com/962801

http://code.google.com/p/google-web-toolkit/source/detail?r=8957

Modified:
 /trunk/user/super/com/google/gwt/emul/java/util/AbstractCollection.java

=======================================
--- /trunk/user/super/com/google/gwt/emul/java/util/AbstractCollection.java Fri Jun 13 17:45:25 2008 +++ /trunk/user/super/com/google/gwt/emul/java/util/AbstractCollection.java Wed Oct 6 09:35:36 2010
@@ -142,7 +142,8 @@
       } else {
         comma = ", ";
       }
-      sb.append(String.valueOf(iter.next()));
+      E value = iter.next();
+ sb.append(value == this ? "(this Collection)" : String.valueOf(value));
     }
     sb.append("]");
     return sb.toString();

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to