LGTM with 2 comments

http://gwt-code-reviews.appspot.com/982801/diff/1/13
File user/src/com/google/gwt/view/client/RangeChangeEvent.java (right):

http://gwt-code-reviews.appspot.com/982801/diff/1/13#newcode51
user/src/com/google/gwt/view/client/RangeChangeEvent.java:51: public
static <T> void fire(HasRows source, Range range) {
I don't think the type parameter is ever actually used -- just delete it

http://gwt-code-reviews.appspot.com/982801/diff/1/14
File user/src/com/google/gwt/view/client/RowCountChangeEvent.java
(right):

http://gwt-code-reviews.appspot.com/982801/diff/1/14#newcode51
user/src/com/google/gwt/view/client/RowCountChangeEvent.java:51: public
static <T> void fire(HasRows source, int rowCount, boolean isExact) {
I don't think the type parameter is ever actually used -- just delete it

http://gwt-code-reviews.appspot.com/982801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to