LGTM

with nits


http://gwt-code-reviews.appspot.com/982802/diff/1/4
File user/src/com/google/gwt/user/client/Command.java (right):

http://gwt-code-reviews.appspot.com/982802/diff/1/4#newcode49
user/src/com/google/gwt/user/client/Command.java:49: public interface
Command extends Scheduler.ScheduledCommand {
If you're not deprecating this one, that cuts the legs out from under my
argument against adding it to 2.1

http://gwt-code-reviews.appspot.com/982802/diff/1/4#newcode50
user/src/com/google/gwt/user/client/Command.java:50: // NB: Extends
ScheduledCommand to help migrate from DeferredCommand API
Looks like javadoc to me

http://gwt-code-reviews.appspot.com/982802/diff/1/5
File user/src/com/google/gwt/user/client/DeferredCommand.java (right):

http://gwt-code-reviews.appspot.com/982802/diff/1/5#newcode27
user/src/com/google/gwt/user/client/DeferredCommand.java:27: *
  API prevents effective mocking.
I thought it was deprecated because it was redundant...TMI?

http://gwt-code-reviews.appspot.com/982802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to