LGTM presuming a good answer to:

So this is to ensure that the RequestFactoryGenerator can handle things the
following, right?

@Service(com.google.gwt.requestfactory.server.SimpleFoo
<http://www.google.com/url?sa=D&q=http://go.corp.google.com/jsearch-gwt/com/google/gwt/requestfactory/server/SimpleFoo.html>.*class*)*public*
*interface* *TestFooPolymorphicRequest* *extends* RequestContext {
  <P *extends* SimpleFooProxy> Request<P> echo(P proxy);
}

Do we know what happens to the rest of the chain if someone actually tries
to call such a method?

rjrjr

On Wed, Oct 13, 2010 at 10:32 AM, <[email protected]> wrote:

> Reviewers: rjrjr,
>
> Description:
> Resolve GWT issue 5364.
> Enable RequestFactoryPolymorphicTest.
> Consolidate base-type code in ModelUtils.
> Patch by: bobv
> Review by: rjrjr
>
>
> Please review this at http://gwt-code-reviews.appspot.com/992801/show
>
> Affected files:
>  M user/src/com/google/gwt/editor/rebind/AutoBeanFactoryGenerator.java
>  M user/src/com/google/gwt/editor/rebind/model/AutoBeanFactoryModel.java
>  M user/src/com/google/gwt/editor/rebind/model/ModelUtils.java
>  M
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
>  M
> user/src/com/google/gwt/requestfactory/rebind/model/EntityProxyModel.java
>  M
> user/src/com/google/gwt/requestfactory/rebind/model/RequestFactoryModel.java
>  M user/test/com/google/gwt/requestfactory/RequestFactorySuite.java
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to