I'm getting cold feet about this change, especially when we're trying to
freeze 2.1

One problem is that this will break
com.google.gwt.event.shared.HandlerManagerTest.testConcurrentAdd(),
which still assumes that adds are deferred. And it will likewise break
any existing apps that are relying on that behavior of HandlerManager
(accidentally or otherwise). I suppose we could give the package
protected constructor another argument, SimpleEventBus(boolean
fireInReverseOrder, boolean deferAdds)?

I'm also uncomfortable with the lack of parallelism — when I add another
handler it's added immediately, but a remove happens later. If we make
the removes happen immediately, people will rely on the order that
handlers are called even more than they do already, not a great thing.
Am I worrying too much?

If we don't make this change, it's consistent and clear when adds and
removes happen: not now, so if I'm doing an add I'll also have to call
the thing myself if that's what I want. I'll have to learn that lesson,
like you did, but I have control.

I think we should pass on this. Sorry, Stephen.

http://gwt-code-reviews.appspot.com/979801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to