Made changes and re-uploaded to rietveld On Thu, Oct 14, 2010 at 12:58 PM, <[email protected]> wrote: > Thanks for doing this. > > LGTM, with nits. > > > http://gwt-code-reviews.appspot.com/1002801/diff/1/2 > File user/src/com/google/gwt/editor/client/AutoBean.java (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/2#newcode57 > user/src/com/google/gwt/editor/client/AutoBean.java:57: * @return the > tage value > tage > > http://gwt-code-reviews.appspot.com/1002801/diff/1/2#newcode66 > user/src/com/google/gwt/editor/client/AutoBean.java:66: * @return true > if this instance is frozen > {...@code true}, here and elsewhere > > http://gwt-code-reviews.appspot.com/1002801/diff/1/2#newcode97 > user/src/com/google/gwt/editor/client/AutoBean.java:97: * If the > AutoBean wraps an object, return the underlying object. > Add "The AutoBean will no longer function once unwrapped." > > http://gwt-code-reviews.appspot.com/1002801/diff/1/2#newcode99 > user/src/com/google/gwt/editor/client/AutoBean.java:99: * @return the > wrapped object > the previously-wrapped object > > http://gwt-code-reviews.appspot.com/1002801/diff/1/3 > File user/src/com/google/gwt/editor/client/AutoBeanFactory.java (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/3#newcode18 > user/src/com/google/gwt/editor/client/AutoBeanFactory.java:18: import > sun.security.jca.GetInstance.Instance; > Bad import. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/3#newcode99 > user/src/com/google/gwt/editor/client/AutoBeanFactory.java:99: * @param > <T> the type of the created {...@link AutoBean} > the parameterization of the the created {...@link AutoBean}. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/3#newcode101 > user/src/com/google/gwt/editor/client/AutoBeanFactory.java:101: * > @return an {...@link AutoBean} of type T > Here and below: "... or {...@code null} if the interface type is unknown > to the factory" > > http://gwt-code-reviews.appspot.com/1002801/diff/1/3#newcode111 > user/src/com/google/gwt/editor/client/AutoBeanFactory.java:111: * @param > clazz the Class of type T of the new {...@link Instance} > {...@link Instance} looks unintentional. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/4 > File user/src/com/google/gwt/editor/client/AutoBeanUtils.java (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/4#newcode131 > user/src/com/google/gwt/editor/client/AutoBeanUtils.java:131: * @param > delegate a delegate object, or null > Here and below: {...@code null} > > http://gwt-code-reviews.appspot.com/1002801/diff/1/5 > File user/src/com/google/gwt/editor/client/AutoBeanVisitor.java (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/5#newcode35 > user/src/com/google/gwt/editor/client/AutoBeanVisitor.java:35: * @return > true if the property can be set > {...@code true} > > http://gwt-code-reviews.appspot.com/1002801/diff/1/5#newcode43 > user/src/com/google/gwt/editor/client/AutoBeanVisitor.java:43: * @return > a Class object representing the element type > or {...@code null} if the property is not a collection type > > http://gwt-code-reviews.appspot.com/1002801/diff/1/5#newcode72 > user/src/com/google/gwt/editor/client/AutoBeanVisitor.java:72: * TODO: > document. > Called after visiting a reference property. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/5#newcode83 > user/src/com/google/gwt/editor/client/AutoBeanVisitor.java:83: * TODO: > document. > Called after visiting a value property. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/6 > File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/6#newcode93 > user/src/com/google/gwt/editor/client/CompositeEditor.java:93: * Used to > implement {...@link EditorDelegate#getPath()}. > ... for the component Editors. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/6#newcode95 > user/src/com/google/gwt/editor/client/CompositeEditor.java:95: * @param > subEditor an instance of the Editor type > ... previously passed into {...@link EditorChain#attach()} > > http://gwt-code-reviews.appspot.com/1002801/diff/1/6#newcode101 > user/src/com/google/gwt/editor/client/CompositeEditor.java:101: * Sets > the {...@link EditorChain}. > Called by the Editor framework to provide the {...@link EditorChain}. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/8 > File user/src/com/google/gwt/editor/client/EditorError.java (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/8#newcode75 > user/src/com/google/gwt/editor/client/EditorError.java:75: * @return > true if the error will not be propagated > {...@code true} > > http://gwt-code-reviews.appspot.com/1002801/diff/1/11 > File user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java > (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/11#newcode70 > user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:70: * > @return true if errors are present > {...@code true} > > http://gwt-code-reviews.appspot.com/1002801/diff/1/14 > File user/src/com/google/gwt/editor/client/adapters/ListEditor.java > (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/14#newcode60 > user/src/com/google/gwt/editor/client/adapters/ListEditor.java:60: // > TODO - document > Creates a temporary sub-Editor to use for traversal. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/14#newcode75 > user/src/com/google/gwt/editor/client/adapters/ListEditor.java:75: * > @return a List of {...@link Editor}s of type E > {...@link Editor Editors} > > http://gwt-code-reviews.appspot.com/1002801/diff/1/14#newcode97 > user/src/com/google/gwt/editor/client/adapters/ListEditor.java:97: * > @return a List of data objects of type T > a live view of the ListEditor's backing data > > http://gwt-code-reviews.appspot.com/1002801/diff/1/15 > File > user/src/com/google/gwt/editor/client/adapters/OptionalFieldEditor.java > (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/15#newcode72 > user/src/com/google/gwt/editor/client/adapters/OptionalFieldEditor.java:72: > // TODO - document > Returns the sub-Editor that the OptionalFieldEditor was constructed > with. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/17 > File > user/src/com/google/gwt/editor/client/adapters/TakesValueEditor.java > (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/17#newcode29 > user/src/com/google/gwt/editor/client/adapters/TakesValueEditor.java:29: > * peer instance. > Here and below: Returns a new ValueEditor that modifies the given > {...@liink TakesValue} peer instance. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/19 > File user/src/com/google/gwt/editor/client/package.html (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/19#newcode3 > user/src/com/google/gwt/editor/client/package.html:3: <p>A framework for > editing bean objects.</p> > bean-like > > We're not really implementing the full-on Bean library. > > http://gwt-code-reviews.appspot.com/1002801/diff/1/21 > File > user/src/com/google/gwt/editor/ui/client/adapters/HasTextEditor.java > (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/21#newcode26 > user/src/com/google/gwt/editor/ui/client/adapters/HasTextEditor.java:26: > * Returns a new ValueEditor that holds a value given by a {...@link > HasText} > Here and below: that modifies the given {...@link HasText} peer instance > > http://gwt-code-reviews.appspot.com/1002801/diff/1/22 > File > user/src/com/google/gwt/editor/ui/client/adapters/ValueBoxEditor.java > (right): > > http://gwt-code-reviews.appspot.com/1002801/diff/1/22#newcode94 > user/src/com/google/gwt/editor/ui/client/adapters/ValueBoxEditor.java:94: > * Sets the {...@link EditorDelegate} for this instance. > This method is only called by the driver. > > http://gwt-code-reviews.appspot.com/1002801/show >
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
