LGTM - but it looks like you copy and pasted "Classes used for testing
GWT." and forgot to update it.


http://gwt-code-reviews.appspot.com/1027801/diff/1/4
File dev/core/src/com/google/gwt/util/package.html (right):

http://gwt-code-reviews.appspot.com/1027801/diff/1/4#newcode3
dev/core/src/com/google/gwt/util/package.html:3: An annotation used to
mark package-info.java classes.
Does this belong in the package info?  Which annotation are you
referring to?

http://gwt-code-reviews.appspot.com/1027801/diff/1/14
File user/src/com/google/gwt/core/client/CodeDownloadException.java
(left):

http://gwt-code-reviews.appspot.com/1027801/diff/1/14#oldcode43
user/src/com/google/gwt/core/client/CodeDownloadException.java:43:
public final Reason getReason() {
I'm not against removing this, but did somebody mention that it was
overly restrictive?

http://gwt-code-reviews.appspot.com/1027801/diff/1/23
File user/src/com/google/gwt/package.html (right):

http://gwt-code-reviews.appspot.com/1027801/diff/1/23#newcode3
user/src/com/google/gwt/package.html:3: Classes used for testing GWT.
This doesn't seem right.  Did you mean to put it in
user/test/com/google/gwt?

http://gwt-code-reviews.appspot.com/1027801/diff/1/27
File user/src/com/google/gwt/requestfactory/client/testing/package.html
(right):

http://gwt-code-reviews.appspot.com/1027801/diff/1/27#newcode3
user/src/com/google/gwt/requestfactory/client/testing/package.html:3:
Classes used for testing GWT.
Classes used for testing RequestFactory.

http://gwt-code-reviews.appspot.com/1027801/diff/1/37
File user/src/com/google/gwt/text/shared/testing/package.html (right):

http://gwt-code-reviews.appspot.com/1027801/diff/1/37#newcode3
user/src/com/google/gwt/text/shared/testing/package.html:3: Classes used
for testing GWT.
Incorrect?

http://gwt-code-reviews.appspot.com/1027801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to